[4.2] Add automatic module name to the manifest #2504
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yrodiere
reviewed
Sep 18, 2025
Member
yrodiere
left a comment
yrodiere
left a comment
There was a problem hiding this comment.
LGTM, let's merge and backport the second commit (about wrong package being used)?
yrodiere
approved these changes
Sep 18, 2025
DavideD
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also moved the
ReactivePersistenceContextAdapterout oforg.hibernate.engine.internalso that there won't be a "split package thing" and it seems all worked ok (at least locally except some links in the javadocs of that class, which is ... ok)