Better error message when transparently loading lazy fields #2513
+632
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 16, 2025
DavideD
reviewed
Sep 24, 2025
...sts/bytecode-enhancements-it/src/test/java/org/hibernate/reactive/it/LazyBasicFieldTest.java
Show resolved
Hide resolved
hibernate-reactive-core/src/main/java/org/hibernate/reactive/logging/impl/Log.java
Show resolved
Hide resolved
| } ); | ||
| } | ||
| else { | ||
| return completedFuture( (T) entityPersister.getPropertyValue( entity, attributeName ) ); |
There was a problem hiding this comment.
If I understand correctly, this change will prevent an extra query. Could you make sure we test for it?
Otherwise, future changes might remove the improvement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1770
This PR aims to intercept direct access to lazy fields in order to throw a better error message, see ReactiveEnhancementAsProxyLazinessInterceptor and ReactiveLazyAttributeLoadingInterceptor
This PR needs hibernate/hibernate-orm#10950