Add CurvePlanarEllipticalCylindrical JAX curve and tests#607
Open
Add CurvePlanarEllipticalCylindrical JAX curve and tests#607
Conversation
Elliptical planar curves in cylindrical pose with full docstrings (including math definition and comparison to CurvePlanarFourier). Export from geo package and add unit tests. Made-with: Cursor
Contributor
Author
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #607 +/- ##
==========================================
+ Coverage 90.15% 90.20% +0.05%
==========================================
Files 84 85 +1
Lines 17895 17981 +86
==========================================
+ Hits 16133 16220 +87
+ Misses 1762 1761 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Elliptical planar curves in cylindrical pose with full docstrings (including math definition and comparison to CurvePlanarFourier). This is used a fair bit for the dipole and passive coil array branch, and has the nice feature that it directly parametrizes elliptical curves, rather than the fiddling you have to do with CurvePlanarFourier.