-
-
Notifications
You must be signed in to change notification settings - Fork 102
Add GUILD_MEDIA
channel type
#2409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davfsa
reviewed
Jun 12, 2025
Co-authored-by: davfsa <davfsa@gmail.com> Signed-off-by: Forbidden A <Forbidden.BA@ProtonMail.com>
davfsa
approved these changes
Jun 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds support for the new GUILD_MEDIA
channel type across the library and tests.
- Implements
create_guild_media_channel
in the REST client and API layers - Introduces
GuildMediaChannel
model and deserialization logic - Adds unit tests for REST call and entity factory deserialization
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
tests/hikari/impl/test_rest.py | Added test_create_guild_media_channel to validate REST call |
tests/hikari/impl/test_entity_factory.py | Added tests for deserialize_guild_media_channel and edge cases |
hikari/impl/rest.py | Implemented create_guild_media_channel in the REST client |
hikari/impl/entity_factory.py | Added deserialize_guild_media_channel and mapping for new type |
hikari/channels.py | Defined ChannelType.GUILD_MEDIA and GuildMediaChannel |
hikari/api/rest.py | Declared abstract create_guild_media_channel and updated docs |
hikari/api/entity_factory.py | Declared abstract deserialize_guild_media_channel |
changes/2409.feature.md | Documented the feature addition |
Comments suppressed due to low confidence (1)
hikari/api/rest.py:4727
- [nitpick] This parameter refers to the channel's position within the guild, not the category. Please update the description to avoid confusion.
position
If provided, the position of the category.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
nox
and all the pipelines have passed.Related issues
Close #2407