Skip to content

Add GUILD_MEDIA channel type #2409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Jun 13, 2025
Merged

Conversation

Forbidden-A
Copy link
Contributor

@Forbidden-A Forbidden-A commented Jun 8, 2025

Summary

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Related issues

Close #2407

@Forbidden-A Forbidden-A marked this pull request as ready for review June 8, 2025 20:06
Forbidden-A and others added 3 commits June 12, 2025 23:00
@davfsa davfsa requested a review from Copilot June 13, 2025 22:40
@davfsa davfsa merged commit 29a1adc into hikari-py:master Jun 13, 2025
22 of 24 checks passed
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for the new GUILD_MEDIA channel type across the library and tests.

  • Implements create_guild_media_channel in the REST client and API layers
  • Introduces GuildMediaChannel model and deserialization logic
  • Adds unit tests for REST call and entity factory deserialization

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/hikari/impl/test_rest.py Added test_create_guild_media_channel to validate REST call
tests/hikari/impl/test_entity_factory.py Added tests for deserialize_guild_media_channel and edge cases
hikari/impl/rest.py Implemented create_guild_media_channel in the REST client
hikari/impl/entity_factory.py Added deserialize_guild_media_channel and mapping for new type
hikari/channels.py Defined ChannelType.GUILD_MEDIA and GuildMediaChannel
hikari/api/rest.py Declared abstract create_guild_media_channel and updated docs
hikari/api/entity_factory.py Declared abstract deserialize_guild_media_channel
changes/2409.feature.md Documented the feature addition
Comments suppressed due to low confidence (1)

hikari/api/rest.py:4727

  • [nitpick] This parameter refers to the channel's position within the guild, not the category. Please update the description to avoid confusion.
position
            If provided, the position of the category.

@Forbidden-A Forbidden-A deleted the feat/media-channel branch June 13, 2025 22:44
@davfsa davfsa mentioned this pull request Jun 13, 2025
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for channel type 16 (media channels)
3 participants