Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the SFA fallback by default #149

Merged
merged 1 commit into from
May 30, 2024

Conversation

dmulder
Copy link
Collaborator

@dmulder dmulder commented May 30, 2024

Just because an SFA fallback is permitted by
Azure, doesn't mean we should attempt it by
default. This disables SFA unless explicitly
enabled via configuration.

Fixes #

Checklist

  • This pr contains no AI generated code
  • cargo fmt has been run
  • cargo clippy has been run
  • A functionality test has been added
  • make test has been run and passes

@dmulder dmulder force-pushed the dmulder/disable_sfa_fallback_default branch 2 times, most recently from 6ce7843 to f6faa4b Compare May 30, 2024 18:19
Just because an SFA fallback is permitted by
Azure, doesn't mean we should attempt it by
default. This disables SFA unless explicitly
enabled via configuration.

Signed-off-by: David Mulder <dmulder@samba.org>
@dmulder dmulder force-pushed the dmulder/disable_sfa_fallback_default branch from f6faa4b to a4a85b0 Compare May 30, 2024 18:33
@dmulder dmulder merged commit 6371e30 into main May 30, 2024
4 checks passed
@dmulder dmulder deleted the dmulder/disable_sfa_fallback_default branch May 30, 2024 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant