Rework the poll logic #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes the daemon doesn't get the message to terimate polling. Rework the logic to only poll when explicitly requested by the PAM module. A necessary side-effect is that this required some work on the aad-tool auth-test command, fixing some pam cases. Signed-off-by: David Mulder <dmulder@samba.org>
Signed-off-by: David Mulder <dmulder@samba.org>
Signed-off-by: David Mulder <dmulder@samba.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #219
This is meant to address the issues in #219. Unfortunately, it appears that SSHD is not terminating the auth attempt when the ssh session times out. There isn't really anything we can do about that. We can however, handle this a little better in the communication between the daemon and the pam module. Now the daemon will do nothing unless prompted by the pam module (when polling). I also added code to honor the DAG timeout specified by Microsoft at init time.
Checklist