Intergrate CI #24
Draft
Intergrate CI #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to cache the dependencies - installing them takes too long! |
Why3 on my local machine is 1.7.2. Bump to 1.8.0 and make sure that the build works.
The problem is inside `simplify_pure`, which is quite surprising. The problem is that, `simplify_pure` will keep simplify our formula until convergence, which is denoted by a boolean. There is a mistake somewhere with the boolean, such that the loop never exits. The current fix is to bound the loop with another parameter "fuel", which is decreased by 1 after each iteration. Once the fuel is exhausted we will stop the loop (this is a technique that is used in Coq to write non-structurally recursive function). By the way, the way we write "simplify_term" and "simplify_pure" is too messy, but it is not our top priority now to fix that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge changes from ci branch into master.