Dev2.5.18 limit caption lines to 2 #212
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After some search I've found that the line-height are set "normal", which seems 1.2 for western fonts but 1.5 for Japanese fonts. So I set 1.3. We need to set this anyway, otherwise the calculation of max-height of the caption window is not possible.
hiroshisuga
added a commit
that referenced
this pull request
Jun 18, 2023
hiroshisuga
added a commit
that referenced
this pull request
Jun 18, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Limit the max size of the caption window to 2 lines in most of the case. But It can be three or four, depending on how fast you speak.
It reads the size of the caption box from the previous rendering. So it is possible to get a very large caption box when suddenly get a loong sentence. Translation might be the case.
#216 is essential.
Showing avatar commit (already merged in #203 and #201) should also be merged together with this PR.
Closes Issue(s)
Closes #
Motivation
More