Dev2.5.18 generate external_videos.xml for playing on the fly #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiroshisuga
changed the title
add: include_external_videos: true which will be used in publish/presentation.rb
generate shapes.svg and presentation/externalVideo.png for thumbnails of external videos
|
Kudos, SonarCloud Quality Gate passed!
|
stupid mistake
Condition to record the external video playing fixed.
Revert one condition, which however seems unnecessary..
Omit 'round' for this.player.getCurrentTime() so that the player time becomes float.
remove .to_i for making the timestamp float in the external_video.xml file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Generate external_videos.xml for play it back on the fly.
See: bigbluebutton/bbb-playback#127
You need to directly modify the script /usr/local/bigbluebutton/core/lib/recordandplayback/generators/events.rb and
/usr/local/bigbluebutton/core/scripts/publish/presentation.rb and
/usr/local/bigbluebutton/core/scripts/presentation.yml
Closes Issue(s)
Closes #
Motivation
More