Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: callback to intercept and modify predicates before re-registration #675

Open
wants to merge 2 commits into
base: stacks-signers
Choose a base branch
from
Open

feat: callback to intercept and modify predicates before re-registration #675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0faf121
feat: callback to intercept and modify predicates before re-registration
zone117x Oct 31, 2024
9ffe84c
fix: overlapping healthchecks
zone117x Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions components/client/typescript/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import { Static, Type } from '@fastify/type-provider-typebox';
import { BitcoinIfThisOptionsSchema, BitcoinIfThisSchema } from './schemas/bitcoin/if_this';
import { StacksIfThisOptionsSchema, StacksIfThisSchema } from './schemas/stacks/if_this';
import { logger } from './util/logger';
import { PredicateSchema } from './schemas/predicate';

const EventObserverOptionsSchema = Type.Object({
/** Event observer host name (usually '0.0.0.0') */
Expand Down Expand Up @@ -40,6 +41,9 @@ const EventObserverOptionsSchema = Type.Object({
* up to date. If they become obsolete, we will attempt to re-register them.
*/
predicate_health_check_interval_ms: Type.Optional(Type.Integer({ default: 5000 })),
predicate_re_register_callback: Type.Optional(
Type.Function([PredicateSchema], Type.Promise(PredicateSchema))
),
});
/** Chainhook event observer configuration options */
export type EventObserverOptions = Static<typeof EventObserverOptionsSchema>;
Expand Down Expand Up @@ -126,14 +130,24 @@ export class ChainhookEventObserver {
this.fastify = await buildServer(this.observer, this.chainhook, predicates, callback);
await this.fastify.listen({ host: this.observer.hostname, port: this.observer.port });
if (this.observer.predicate_health_check_interval_ms && this.healthCheckTimer === undefined) {
this.healthCheckTimer = setInterval(() => {
predicateHealthCheck(this.observer, this.chainhook).catch(err =>
logger.error(err, `ChainhookEventObserver predicate health check error`)
);
}, this.observer.predicate_health_check_interval_ms);
this.scheduleHealthCheck();
}
}

private scheduleHealthCheck() {
this.healthCheckTimer = setTimeout(() => {
void predicateHealthCheck(this.observer, this.chainhook)
.catch(err => {
logger.error(err, `ChainhookEventObserver predicate health check error`);
})
.finally(() => {
if (this.healthCheckTimer) {
this.scheduleHealthCheck();
}
});
}, this.observer.predicate_health_check_interval_ms);
}

/**
* Stop the Chainhook event server gracefully.
*/
Expand Down
6 changes: 5 additions & 1 deletion components/client/typescript/src/predicates.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,11 +146,15 @@ async function registerPredicate(
authorization_header: `Bearer ${observer.auth_token}`,
},
};
const newPredicate = pendingPredicate as Predicate;
let newPredicate = pendingPredicate as Predicate;
newPredicate.uuid = randomUUID();
if (newPredicate.networks.mainnet) newPredicate.networks.mainnet.then_that = thenThat;
if (newPredicate.networks.testnet) newPredicate.networks.testnet.then_that = thenThat;

if (observer.predicate_re_register_callback) {
newPredicate = await observer.predicate_re_register_callback(newPredicate);
}

const path = observer.node_type === 'chainhook' ? `/v1/chainhooks` : `/v1/observers`;
await request(`${chainhook.base_url}${path}`, {
method: 'POST',
Expand Down
Loading