-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
propagate error when storing peer_info #682
Conversation
6616145
to
c7d14ca
Compare
I was able to look at this briefly and I strongly suspect the problem is that we're being unable to write some of the I noticed the problem could lie here, where we're not propagating a possible write error to the caller so we never notice the peer info wasn't written to the DB. (Oops, my bad) @csgui could you add a |
c7d14ca
to
1bc949a
Compare
@rafaelcr Thanks for the swift reply! Added the error propagation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @csgui ! We should try this out in mainnet and I'm pretty sure the DB write error will stick out pretty quickly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @csgui!
🎉 This PR is included in version 1.9.0-stacks-signers.7 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Adds error propagation when trying to insert
peer_info
data.