Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/footer #1972

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Feat/footer #1972

wants to merge 1 commit into from

Conversation

BLuEScioN
Copy link
Collaborator

What type of PR is this? (check all applicable)

  • Refactor
  • Feature
  • Bug Fix
  • Optimization
  • Documentation Update

Description

Adds the footer
Designs here https://www.figma.com/design/zR7MN402tgacWXm63OQLms/Stacks-Explorer-Design-System-%5BRedesign%5D?node-id=2563-20543&m=dev
I do not see any common components that can be extracted from this work in to storybook

I need to comment out the pages that don't exist yet

Issue ticket number and link

Checklist:

  • I have performed a self-review of my code.
  • I have tested the change on desktop and mobile.
  • I have added thorough tests where applicable.
  • I've added analytics and error logging where applicable.

Screenshots (if appropriate):

Copy link

vercel bot commented Jan 22, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 7:47pm
hiro-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 7:47pm

Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/app/_components/Footer/StacksSmiley.tsx 0.00% 16 Missing ⚠️
src/app/_components/NewFooter.tsx 0.00% 15 Missing ⚠️
src/app/_components/PageWrapper.tsx 0.00% 4 Missing ⚠️
src/common/utils/url-utils.ts 0.00% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

1 participant