Skip to content

Clarify network overview tooltip timeframe #2246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alexthuth
Copy link
Contributor

Summary

  • add explanatory text to Network Overview tooltip
  • test ChartTooltip renders new timeframe text

Issue

Fixes #2215

Design Decisions

  • leverage existing typography and colors for the extra tooltip line
  • use renderWithProviders in tests to satisfy cookies/context requirements

Testing

  • pnpm lint
  • pnpm test:unit
  • pnpm build (fails: connect EHOSTUNREACH 172.24.0.3:8080)

Copy link

vercel bot commented May 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
explorer-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 7:43pm
hiro-explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 21, 2025 7:43pm

Copy link

codecov bot commented May 19, 2025

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...c/app/_components/NetworkOverview/ChartTooltip.tsx 50.00% 1 Missing and 1 partial ⚠️
...pp/_components/NetworkOverview/NetworkOverview.tsx 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@alexthuth
Copy link
Contributor Author

image
Updated image

@He1DAr He1DAr force-pushed the feat/explorer-hybrid-version branch from a67988a to ae16af9 Compare May 20, 2025 20:35
@BLuEScioN BLuEScioN force-pushed the codex/design-tooltip-clarity-for-network-overview branch from 8202660 to 08e4a26 Compare May 21, 2025 19:30
@BLuEScioN
Copy link
Collaborator

Codex code was good, but I don't think it improved the clarity much with the tooltip it wrote. I changed it to this:

image

@BLuEScioN BLuEScioN merged commit 42d8594 into feat/explorer-hybrid-version May 21, 2025
12 of 14 checks passed
@BLuEScioN BLuEScioN deleted the codex/design-tooltip-clarity-for-network-overview branch May 21, 2025 21:04
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Stacks Explorer May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants