Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove unneeded deserialize overloads #1750

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

janniks
Copy link
Collaborator

@janniks janniks commented Oct 23, 2024

This PR was published to npm with the version 6.14.1-pr.82+695a0c7d
e.g. npm install @stacks/common@6.14.1-pr.82+695a0c7d --save-exact

  • reverting the Bytes overload for deserialize, since it doesn't really make sense.

Copy link

vercel bot commented Oct 23, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stacksjs-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 25, 2024 7:03pm

Copy link

codecov bot commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 86.88525% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/transactions/src/wire/serialization.ts 82.97% 8 Missing ⚠️

📢 Thoughts on this report? Let us know!

@janniks janniks force-pushed the 10-23-refactor_remove_unneeded_deserialize_overloads branch from c0ef9c2 to 4db76a6 Compare October 23, 2024 19:43
@janniks janniks force-pushed the 10-22-refactor_minor_refactoring_to_match_common_theme branch from 991a12b to 620a507 Compare October 23, 2024 19:43
@janniks janniks force-pushed the 10-22-refactor_minor_refactoring_to_match_common_theme branch from 620a507 to f8dba25 Compare October 24, 2024 15:12
@janniks janniks force-pushed the 10-23-refactor_remove_unneeded_deserialize_overloads branch from 4db76a6 to 8a72ccb Compare October 24, 2024 15:12
@janniks janniks force-pushed the 10-23-refactor_remove_unneeded_deserialize_overloads branch from 8a72ccb to 695a0c7 Compare October 25, 2024 12:05
@janniks janniks force-pushed the 10-22-refactor_minor_refactoring_to_match_common_theme branch from f8dba25 to e6f2832 Compare October 25, 2024 12:05
@janniks janniks force-pushed the 10-23-refactor_remove_unneeded_deserialize_overloads branch from 695a0c7 to 8c4466d Compare October 25, 2024 18:55
@janniks janniks force-pushed the 10-22-refactor_minor_refactoring_to_match_common_theme branch 2 times, most recently from 0676a06 to fa9be48 Compare October 25, 2024 18:55
@janniks janniks force-pushed the 10-23-refactor_remove_unneeded_deserialize_overloads branch from 8c4466d to 74cb952 Compare October 25, 2024 18:55
Base automatically changed from 10-22-refactor_minor_refactoring_to_match_common_theme to next October 25, 2024 18:55
@janniks janniks force-pushed the 10-23-refactor_remove_unneeded_deserialize_overloads branch from 74cb952 to 06980cf Compare October 25, 2024 18:55
@janniks janniks merged commit f1f5d9c into next Oct 25, 2024
6 of 7 checks passed
@janniks janniks deleted the 10-23-refactor_remove_unneeded_deserialize_overloads branch October 25, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants