Add various abo fees as mounted attrs (#1590) #1619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
njaeggi
commented
Feb 4, 2025
| SacCas::ABO_COSTS[:magazin].find { |cost| cost.country == :international } | ||
| end | ||
| cost = Group.root.abo_alpen_fee | ||
| cost += Group.root.abo_alpen_postage_abroad if @person.living_abroad? |
There was a problem hiding this comment.
In any other place where abroad fees are applied, we use living_abroad? to to not apply costs to Liechtenstein, this should probably be the same here 😄
njaeggi
force-pushed
the
feature/1590/abo-fee-configuration
branch
2 times, most recently
from
c01276b to
1e1d7c3
Compare
njaeggi
force-pushed
the
feature/1590/abo-fee-configuration
branch
from
1e1d7c3 to
036c105
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.