Cherry-pick: Capture telemetry when git errors on unsafe repository. (a…

…ctions#1823) (actions#1827)

* Capture telemetry when git errors on unsafe repository. (actions#1823)

* Release 2.290.1 runner.

releaseNote.md

@@ -13,6 +13,7 @@
 - Better exception handling when runner is configured with invalid Url or token (#1741)
 - Set user agent for websocket requests (#1791)
 - Gracefully handle websocket failures (#1789)
+- Capture telemetry when git errors on unsafe repository. (#1823)
 
 ## Windows x64
 We recommend configuring the runner in a root folder of the Windows drive (e.g. "C:\actions-runner"). This will help avoid issues related to service identity folder permissions and long file path restrictions on Windows.

releaseVersion

@@ -1 +1 @@
-2.290.0
+2.290.1

src/Runner.Worker/Handlers/OutputManager.cs

@@ -151,6 +151,11 @@ public void OnDataReceived(object sender, ProcessDataReceivedEventArgs e)
                 }
             }
 
+            if (line.Contains("fatal: unsafe repository", StringComparison.OrdinalIgnoreCase))
+            {
+                _executionContext.StepTelemetry.ErrorMessages.Add(line);
+            }
+
             // Regular output
             _executionContext.Output(line);
         }

src/Test/L0/Worker/OutputManagerL0.cs

@@ -3,9 +3,9 @@
 using System.Globalization;
 using System.IO;
 using System.Linq;
+using System.Runtime.CompilerServices;
 using System.Threading;
 using System.Threading.Tasks;
-using System.Runtime.CompilerServices;
 using GitHub.Runner.Sdk;
 using GitHub.Runner.Worker;
 using GitHub.Runner.Worker.Container;
@@ -937,6 +937,19 @@ public async void MatcherFromPath()
             }
         }
 
+        [Fact]
+        [Trait("Level", "L0")]
+        [Trait("Category", "Worker")]
+        public void CaptureTelemetryForGitUnsafeRepository()
+        {
+            using (Setup())
+            using (_outputManager)
+            {
+                Process("fatal: unsafe repository ('/github/workspace' is owned by someone else)");
+                Assert.Contains("fatal: unsafe repository ('/github/workspace' is owned by someone else)", _executionContext.Object.StepTelemetry.ErrorMessages);
+            }
+        }
+
         private TestHostContext Setup(
             [CallerMemberName] string name = "",
             IssueMatchersConfig matchers = null,
@@ -962,6 +975,8 @@ private TestHostContext Setup(
                     Variables = _variables,
                     WriteDebug = true,
                 });
+            _executionContext.Setup(x => x.StepTelemetry)
+                .Returns(new DTWebApi.ActionsStepTelemetry());
             _executionContext.Setup(x => x.GetMatchers())
                 .Returns(matchers?.Matchers ?? new List<IssueMatcherConfig>());
             _executionContext.Setup(x => x.Add(It.IsAny<OnMatcherChanged>()))

src/runnerversion

@@ -1 +1 @@
-2.290.0
+2.290.1