Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust heap size and stack size of JVM of GitHub workflow #201

Merged
merged 3 commits into from
Dec 31, 2023

Conversation

chengluyu
Copy link
Member

@chengluyu chengluyu commented Dec 30, 2023

After pushing commits to PR, sometimes the CI would time out due to spending too much time on GC. The root of the cause is its insufficient memory. Considering that the built-in runner on GitHub has 7 GB of memory, this issue should be improvable. So, I set the maximum memory of JVM that sbt runs on to 4 GB in the GitHub workflow.

I also found that the default stack size (512 KB) is small for some test cases. Therefore, I also increase the stack size to 64 MB.

@chengluyu chengluyu marked this pull request as draft December 30, 2023 20:21
Is 64 MB small or large? I'm not very sure.
Okay, 64 MB is quite large...
@chengluyu chengluyu changed the title Increase the maximum memory limit of GitHub workflow's JVM Adjust heap size and stack size of JVM of GitHub workflow Dec 30, 2023
@chengluyu chengluyu marked this pull request as ready for review December 30, 2023 20:36
@LPTK
Copy link
Contributor

LPTK commented Dec 31, 2023

Is 64 MB small or large? I'm not very sure.

FYI I run things locally with 1M, which should be amply sufficient.

@LPTK LPTK merged commit ea4ddab into mlscript Dec 31, 2023
1 check passed
@LPTK LPTK deleted the github-workflow-memory-size branch December 31, 2023 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants