Add ability to change acceptable steam min volume #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hldh214
approved these changes
Aug 26, 2023
hldh214
approved these changes
Aug 26, 2023
|
I'm sorry if I'm doing something wrong. I'm new to git |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Signed-off-by: hldh214 <hldh214@gmail.com>
hldh214
approved these changes
Oct 31, 2023
buff2steam/__main__.py
Outdated
| @@ -6,7 +6,7 @@ | |||
| from buff2steam.provider.steam import Steam | |||
|
|
|||
|
|
|||
| async def main_loop(buff, steam): | |||
| async def main_loop(buff, steam,min_volume): | |||
buff2steam/__main__.py
Outdated
|
|
||
| current_ratio = buff_min_price / (price_overview_data['price'] / (1 + steam.fee_rate)) | ||
| buff_min_price_human = float(buff_min_price / 100) | ||
|
|
||
| orders_data = None | ||
| if volume > 0: |
There was a problem hiding this comment.
I believe this line is unnecessary since we have already checked using min_volume
buff2steam/__main__.py
Outdated
|
|
||
| current_ratio = buff_min_price / (price_overview_data['price'] / (1 + steam.fee_rate)) | ||
| buff_min_price_human = float(buff_min_price / 100) | ||
|
|
||
| orders_data = None | ||
| if volume > 0: | ||
| if current_ratio < min_ration_for_buyorder: |
There was a problem hiding this comment.
I'm not a native speaker but I just be curious about why we're choosing word ration instead of ratio?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe that this a useful feature since there are a lot of useless items that no one is going to buy