Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP:Accessible name labels for case list check boxes #1810

Merged
merged 11 commits into from
Jan 15, 2025
Merged

WIP:Accessible name labels for case list check boxes #1810

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
1be58f1
retries this fix on a 3rd branch
StoneBenHMCTS Nov 15, 2024
8284e3a
adds new tag
StoneBenHMCTS Nov 18, 2024
473c51a
fixes yarn audit issues
StoneBenHMCTS Nov 18, 2024
92f00eb
adds another new tag
StoneBenHMCTS Nov 18, 2024
75ced36
Merge branch 'master' into feature/exui-2223-pt2.1
StoneBenHMCTS Jan 3, 2025
dee4bb7
updates audit file
StoneBenHMCTS Jan 3, 2025
1bd6c89
updates version number to create new release
StoneBenHMCTS Jan 3, 2025
192a29f
changes TH to TD
StoneBenHMCTS Jan 10, 2025
ac61c82
Merge branch 'master' into feature/exui-2223-pt2.1
StoneBenHMCTS Jan 10, 2025
aad51cd
updates to fix sonar issues
StoneBenHMCTS Jan 10, 2025
70a9cc3
version updated
RiteshHMCTS Jan 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion RELEASE-NOTES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
## RELEASE NOTES

### Version 7.1.26
**EXUI-2223** Accessibility-issue

### Version 7.1.25
**EXUI-1951** etrieve current user language selection
**EXUI-1951** Retrieve current user language selection

### Version 7.1.24
Taken by PR
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@hmcts/ccd-case-ui-toolkit",
"version": "7.1.31-sonarCloud-gitub-config-update",
"version": "7.1.26",
"engines": {
"node": ">=18.19.0"
},
Expand Down
2 changes: 1 addition & 1 deletion projects/ccd-case-ui-toolkit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@hmcts/ccd-case-ui-toolkit",
"version": "7.1.31-sonarCloud-gitub-config-update",
"version": "7.1.26",
"engines": {
"node": ">=18.19.0"
},
Expand Down
14 changes: 7 additions & 7 deletions .../ccd-case-ui-toolkit/src/lib/shared/components/search-result/search-result.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,15 +26,15 @@ <h2 class="heading-h2" id="search-result-heading__text" tabindex="-1">{{ (caseSt
</caption>
<thead>
<tr scope="row">
<th *ngIf="selectionEnabled" class="govuk-table__checkbox" scope="col">
<td *ngIf="selectionEnabled" class="govuk-table__checkbox">
<div class="govuk-checkboxes__item">
<input class="govuk-checkboxes__input" id="select-all" name="select-all" type="checkbox" (change)="selectAll()" [checked]="allOnPageSelected()" [disabled]="!canAnyBeShared()" />
<label class="govuk-label govuk-checkboxes__label" for="select-all">
<label class="govuk-label govuk-checkboxes__label" for="select-all" [attr.aria-labelledby]="'select-all'">
</label>
</div>
</th>
</td>
<th *ngFor="let col of resultView.columns" class="search-result-column-header"
[attr.aria-sort]="isSortAscending(col) === null ? null : (isSortAscending(col) ? 'ascending' : 'descending')">
[attr.aria-sort]="isSortAscending(col) === null ? null : (isSortAscending(col) ? 'ascending' : 'descending')" scope="col">
<div>
<div class="search-result-column-label" (click)="sort(col)" (keyup)="noop()">
{{col.label | rpxTranslate}}
Expand All @@ -44,7 +44,7 @@ <h2 class="heading-h2" id="search-result-heading__text" tabindex="-1">{{ (caseSt
</div>
</div>
</th>
<th *ngIf="activityEnabled()" style="width: 110px;">&ZeroWidthSpace;</th>
<th *ngIf="activityEnabled()" style="width: 110px;" scope="col">&ZeroWidthSpace;</th>
</tr>
</thead>

Expand All @@ -56,7 +56,7 @@ <h2 class="heading-h2" id="search-result-heading__text" tabindex="-1">{{ (caseSt
<div class="govuk-checkboxes__item">
<input class="govuk-checkboxes__input" id="select-{{ result.case_id }}" name="select-{{ result.case_id }}"
type="checkbox" (change)="changeSelection(result)" [checked]="isSelected(result)" [disabled]="!canBeShared(result)" />
<label class="govuk-label govuk-checkboxes__label" for="select-{{ result.case_id }}">
<label class="govuk-label govuk-checkboxes__label" for="select-{{ result.case_id }}" [attr.aria-labelledby]="'select-' + result.case_id">
</label>
</div>
</td>
Expand Down Expand Up @@ -92,7 +92,7 @@ <h2 class="heading-h2" id="search-result-heading__text" tabindex="-1">{{ (caseSt
<div class="govuk-checkboxes__item">
<input class="govuk-checkboxes__input" id="select-{{ result.case_id }}" name="select-{{ result.case_id }}"
type="checkbox" (change)="changeSelection(result)" [checked]="isSelected(result)" [disabled]="!canBeShared(result)" (keyup)="onKeyUp($event, result)" />
<label class="govuk-label govuk-checkboxes__label" for="select-{{ result.case_id }}">
<label class="govuk-label govuk-checkboxes__label" for="select-{{ result.case_id }}" [attr.aria-labelledby]="'select-' + result.case_id">
</label>
</div>
</td>
Expand Down
Loading