Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/query management #1818

Merged
merged 13 commits into from
Dec 16, 2024
Merged

Feature/query management #1818

merged 13 commits into from
Dec 16, 2024

Conversation

olusegz07
Copy link
Contributor

Before creating a pull request make sure that:

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)

Please remove this line and everything above and fill the following sections:

JIRA link (if applicable)

Change description

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[ ] No

@olusegz07 olusegz07 force-pushed the feature/query-management branch from 8bd4bb0 to 7a4b9e1 Compare December 16, 2024 09:33
@olusegz07 olusegz07 force-pushed the feature/query-management branch from 7a4b9e1 to a7d641f Compare December 16, 2024 10:49
@@ -50,6 +50,11 @@ export class QueryListItem implements CaseMessage {
}

public get responseStatus(): QueryItemResponseStatus {
return this.children?.length > 0 ? QueryItemResponseStatus.RESPONDED : QueryItemResponseStatus.NEW;
if (this.children?.length > 0) {
return this.children.length % 2 === 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we find a more robust way of determining if this is responded or new, for example using the associated user Id, or the status of the message or perhaps a change to the data?

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

Copy link
Contributor

@connorpgpmcelroy connorpgpmcelroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@olusegz07 olusegz07 merged commit b6f023b into master Dec 16, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants