-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/query management #1818
Feature/query management #1818
Conversation
…ui-toolkit into feature/query-management
* Update query-case-details-header.component.ts * Update yarn-audit-known-issues * update toolkit version * code tidy and fix sonar cloud issue * code tidy * version update
8bd4bb0
to
7a4b9e1
Compare
7a4b9e1
to
a7d641f
Compare
@@ -50,6 +50,11 @@ export class QueryListItem implements CaseMessage { | |||
} | |||
|
|||
public get responseStatus(): QueryItemResponseStatus { | |||
return this.children?.length > 0 ? QueryItemResponseStatus.RESPONDED : QueryItemResponseStatus.NEW; | |||
if (this.children?.length > 0) { | |||
return this.children.length % 2 === 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we find a more robust way of determining if this is responded or new, for example using the associated user Id, or the status of the message or perhaps a change to the data?
Quality Gate failedFailed conditions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Before creating a pull request make sure that:
Please remove this line and everything above and fill the following sections:
JIRA link (if applicable)
Change description
Does this PR introduce a breaking change? (check one with "x")