EXUI-2595 - Add spinner to event dropdown #1828
Conversation
* Add the fix and tests * version updated
* checking for the availability of Other type reason * version updated * cve * version updated * version updated
* Add readCookieService and language information to client context * Add version * Add additional language setting on clientcontext Event guard also sets it * Make sonar advised change * Add sonar suggested change * Update npmpublish.yml * Add change to make client context always appear with language * version updated * release notes updated * version updated * version updated --------- Co-authored-by: Ritesh Dsouza <ritesh.dsouza@HMCTS.net>
* Update event-start.guard.ts Fix regression issue that overwrites user_task * Change version * Update event-start.guard.ts Add 'en' even if no cookie Add language to existing client_context object, not just object with user_task * Add version * Update event-start.guard.spec.ts Add helpful test * update to rel name --------- Co-authored-by: Josh <josh.glasgow@hmcts.net>
olusegz07
force-pushed
the
branch_frm_d80548e_before_QM
branch
from
1ba5a5b to
b22fa0f
Compare
Josh-HMCTS
changed the base branch from
branch_frm_d80548e_before_QM
to
master
...kit/src/lib/shared/components/case-viewer/case-event-trigger/case-event-trigger.component.ts
Show resolved
Hide resolved
| ) { | ||
| } | ||
|
|
||
| public ngOnInit(): void { | ||
| if (this.loadingService.storedSpinner){ | ||
| this.loadingService.unregisterStoredSpinner(); |
There was a problem hiding this comment.
Good, but I don't like the public variable in loadingService
| @@ -6,6 +6,7 @@ import { distinctUntilChanged } from 'rxjs/operators'; | |||
| export class LoadingService { | |||
| private readonly registered = new Map<string, string>(); | |||
| private readonly loading = new BehaviorSubject<boolean>(false); | |||
| public storedSpinner; | |||
There was a problem hiding this comment.
I don't really understand why you need to do this. It seems like a hack. I certainly frown on using a public variable to store state. The spinner token is already in the registered map somewhere. This is a shared service, so your hack probably only works until some other component starts to mess with your state.
I think you need to analyse this a bit more carefully and think about adding behaviour to the loading service that can be called at the appropriate place in the calling component that will ensure that that the spinner is taken down.
There was a problem hiding this comment.
Have reworked the approach and used private array to store any shared loading spinners
|
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/EXUI-2595
Change description
Add spinner when user triggers event from event dropdown
Does this PR introduce a breaking change? (check one with "x")