EXUI-2595 - Add spinner to event dropdown #1828
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add the fix and tests * version updated
* checking for the availability of Other type reason * version updated * cve * version updated * version updated
* Add readCookieService and language information to client context * Add version * Add additional language setting on clientcontext Event guard also sets it * Make sonar advised change * Add sonar suggested change * Update npmpublish.yml * Add change to make client context always appear with language * version updated * release notes updated * version updated * version updated --------- Co-authored-by: Ritesh Dsouza <ritesh.dsouza@HMCTS.net>
* Update event-start.guard.ts Fix regression issue that overwrites user_task * Change version * Update event-start.guard.ts Add 'en' even if no cookie Add language to existing client_context object, not just object with user_task * Add version * Update event-start.guard.spec.ts Add helpful test * update to rel name --------- Co-authored-by: Josh <josh.glasgow@hmcts.net>
olusegz07
force-pushed
the
branch_frm_d80548e_before_QM
branch
from
1ba5a5b to
b22fa0f
Compare
Josh-HMCTS
changed the base branch from
branch_frm_d80548e_before_QM
to
master
andywilkinshmcts
requested changes
Jan 15, 2025
...kit/src/lib/shared/components/case-viewer/case-event-trigger/case-event-trigger.component.ts
Show resolved
Hide resolved
RiteshHMCTS
previously approved these changes
Jan 15, 2025
andywilkinshmcts
requested changes
Jan 16, 2025
...kit/src/lib/shared/components/case-viewer/case-event-trigger/case-event-trigger.component.ts
Outdated
Show resolved
Hide resolved
projects/ccd-case-ui-toolkit/src/lib/shared/services/loading/loading.service.ts
Outdated
Show resolved
Hide resolved
MunishSharmaHMCTS
previously approved these changes
Jan 20, 2025
RiteshHMCTS
previously approved these changes
Jan 20, 2025
andywilkinshmcts
previously approved these changes
Jan 20, 2025
Josh-HMCTS
dismissed stale reviews from andywilkinshmcts, RiteshHMCTS, and MunishSharmaHMCTS
via
2a1301c
|
Josh-HMCTS
added a commit
that referenced
this pull request
Feb 19, 2025
* Bug/ex UI 2743 check application task not completing (#1848) * EXUI-2551: case view not fully expanded (#1833) * case view not fully expended * yarn audit * update failing test * version update --------- Co-authored-by: RiteshHMCTS <74713687+RiteshHMCTS@users.noreply.github.com> * version updated * Make fix to intermittent issue regarding completing tasks * Add version * Add PR comment changes Edit to deletion of user_task and session storage constants * Add pre-release * Update case-edit.utils.ts * Update case-edit.utils.spec.ts Fix sonar coverage * toolkit version updated * EXUI-2104 - Event History Summary (#1775) * Add check for external user to disable hyperlink on case history * Fix unit tests * Update to prerelease ver name * Remove console.log * add test for external user not being shown hyperlink * set to old sonar version * change version number --------- Co-authored-by: RiteshHMCTS <74713687+RiteshHMCTS@users.noreply.github.com> * Add fix for issue Add taskEventCompletionInfo when client context added via payload * Update case-edit.component.ts * Update event-start.guard.ts * Add tag * Make Sonar issue changes * Fix mock date test * Add version * Update case-edit.component.ts * Change version * revert exui-2551 changes --------- Co-authored-by: MunishSharmaHMCTS <112546702+MunishSharmaHMCTS@users.noreply.github.com> Co-authored-by: RiteshHMCTS <74713687+RiteshHMCTS@users.noreply.github.com> Co-authored-by: Ritesh Dsouza <ritesh.dsouza@HMCTS.net> Co-authored-by: Josh-HMCTS <128602796+Josh-HMCTS@users.noreply.github.com> * EXUI-2595 - Add spinner to event dropdown (#1828) * Add the fix and tests (#1807) * Add the fix and tests * version updated * update yarn audit * change ver num * exui-2515-case-link-issue (#1805) * checking for the availability of Other type reason * version updated * cve * version updated * version updated * Add readCookieService and language information to client context (#1780) * Add readCookieService and language information to client context * Add version * Add additional language setting on clientcontext Event guard also sets it * Make sonar advised change * Add sonar suggested change * Update npmpublish.yml * Add change to make client context always appear with language * version updated * release notes updated * version updated * version updated --------- Co-authored-by: Ritesh Dsouza <ritesh.dsouza@HMCTS.net> * Bug/ex UI 2624 user task missing (#1822) * Update event-start.guard.ts Fix regression issue that overwrites user_task * Change version * Update event-start.guard.ts Add 'en' even if no cookie Add language to existing client_context object, not just object with user_task * Add version * Update event-start.guard.spec.ts Add helpful test * update to rel name --------- Co-authored-by: Josh <josh.glasgow@hmcts.net> * yarn audit * version name * Add spinner when event is triggered * change ver name * fix unit tests * add code coverage * make test more reliable * update to add more conditions where spinner is removed * Update loading service to use an array to store spinners that go between components * update version --------- Co-authored-by: RiteshHMCTS <74713687+RiteshHMCTS@users.noreply.github.com> Co-authored-by: connorpgpmcelroy <74015088+connorpgpmcelroy@users.noreply.github.com> Co-authored-by: Ritesh Dsouza <ritesh.dsouza@HMCTS.net> * marked it as readonly * Fix/exui 2595 (#1871) * Add the fix and tests (#1807) * Add the fix and tests * version updated * update yarn audit * change ver num * exui-2515-case-link-issue (#1805) * checking for the availability of Other type reason * version updated * cve * version updated * version updated * Add readCookieService and language information to client context (#1780) * Add readCookieService and language information to client context * Add version * Add additional language setting on clientcontext Event guard also sets it * Make sonar advised change * Add sonar suggested change * Update npmpublish.yml * Add change to make client context always appear with language * version updated * release notes updated * version updated * version updated --------- Co-authored-by: Ritesh Dsouza <ritesh.dsouza@HMCTS.net> * Bug/ex UI 2624 user task missing (#1822) * Update event-start.guard.ts Fix regression issue that overwrites user_task * Change version * Update event-start.guard.ts Add 'en' even if no cookie Add language to existing client_context object, not just object with user_task * Add version * Update event-start.guard.spec.ts Add helpful test * update to rel name --------- Co-authored-by: Josh <josh.glasgow@hmcts.net> * yarn audit * version name * Add spinner when event is triggered * change ver name * fix unit tests * add code coverage * make test more reliable * update to add more conditions where spinner is removed * Update loading service to use an array to store spinners that go between components * update version * fix for user spamming go button --------- Co-authored-by: RiteshHMCTS <74713687+RiteshHMCTS@users.noreply.github.com> Co-authored-by: connorpgpmcelroy <74015088+connorpgpmcelroy@users.noreply.github.com> Co-authored-by: Ritesh Dsouza <ritesh.dsouza@HMCTS.net> * yarn audit * readd fix from prev srt, up ver num * Remove changes for EXUI-2104 * Update to release version --------- Co-authored-by: connorpgpmcelroy <74015088+connorpgpmcelroy@users.noreply.github.com> Co-authored-by: MunishSharmaHMCTS <112546702+MunishSharmaHMCTS@users.noreply.github.com> Co-authored-by: Josh-HMCTS <128602796+Josh-HMCTS@users.noreply.github.com> Co-authored-by: Josh <josh.glasgow@hmcts.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/EXUI-2595
Change description
Add spinner when user triggers event from event dropdown
Does this PR introduce a breaking change? (check one with "x")