Skip to content

Update ASO documentation to include postgres setup script info #35785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 17, 2025

Conversation

louisehuyton
Copy link
Contributor

@louisehuyton louisehuyton commented Dec 12, 2024

Jira link

DTSPO-18332

Change description

Update documentation to reflect changes made by new postgres-setup script

Testing done

Checklist

  • commit messages are meaningful and follow good commit message guidelines
  • README and other documentation has been updated / added (if needed)
  • tests have been updated / new tests has been added (if needed)
  • Does this PR introduce a breaking change

🤖AEP PR SUMMARY🤖

I'm a bot that generates AI summaries of pull requests, see AEP for more details

  • aso-setup-v2.md 📝

    • Added instructions to run postgres-setup.sh with namespace and app name.
  • secrets-sops-encryption.md 📝

    • Minor formatting adjustments and addition of clarification for using the appropriate key version for the environment.

@louisehuyton louisehuyton marked this pull request as ready for review December 13, 2024 18:11
@louisehuyton louisehuyton requested a review from a team as a code owner December 13, 2024 18:11
@louisehuyton louisehuyton requested review from akozichev, Abhivan, gunnertwin, a team, cpareek, Tyler-35, JordanHoey96, ieuanb74 and ryanmcalary11 and removed request for a team, akozichev, Abhivan and gunnertwin December 13, 2024 18:11
cpareek
cpareek previously approved these changes Dec 16, 2024
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 24, 2024
@github-actions github-actions bot closed this Dec 29, 2024
@louisehuyton louisehuyton reopened this Jan 6, 2025
@github-actions github-actions bot removed the stale label Jan 7, 2025
Copy link
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@@ -44,7 +44,7 @@ metadata:
type: Opaque
```

## Here is where you Encrypt using SOP in Flux V2:
## Encryption of other files:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This applies to all files

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You create the secret unencrypted first and then encrypt

@@ -5,7 +5,7 @@ Install sops:
brew install sops
```

#### Steps to SOPS Encrypt
## Encryption of a helm file:

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This section is more about creating a kubernetes secret that isn't encrypted

@github-actions github-actions bot removed the stale label Jan 16, 2025
@louisehuyton louisehuyton merged commit 5b718c9 into master Jan 17, 2025
18 checks passed
@louisehuyton louisehuyton deleted the ASO_Setup_Postgres_Documentation branch January 17, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants