Skip to content

Commit

Permalink
Merge pull request #423 from hmcts/PUB-2481
Browse files Browse the repository at this point in the history 
PUB-2481 Create system admin account for SSO user
  • Loading branch information
@KianKwa
KianKwa authored Jun 19, 2024
2 parents 9973795 + 0cbeafb commit 10e6565
Show file tree
Hide file tree
Showing 13 changed files with 919 additions and 348 deletions.
97 changes: 19 additions & 78 deletions ...t/java/uk/gov/hmcts/reform/pip/account/management/controllers/SystemAdminAccountTest.java
View file
Original file line number Diff line number Diff line change
@@ -1,17 +1,9 @@
package uk.gov.hmcts.reform.pip.account.management.controllers;

import com.fasterxml.jackson.databind.ObjectMapper;
import com.microsoft.graph.models.User;
import com.microsoft.graph.models.UserCollectionResponse;
import com.microsoft.graph.serviceclient.GraphServiceClient;
import com.microsoft.graph.users.UsersRequestBuilder;
import com.microsoft.kiota.ApiException;
import io.zonky.test.db.AutoConfigureEmbeddedDatabase;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.mockito.Mockito;
import org.springframework.beans.factory.annotation.Autowired;
import org.springframework.boot.test.autoconfigure.web.servlet.AutoConfigureMockMvc;
import org.springframework.boot.test.context.SpringBootTest;
Expand All @@ -26,16 +18,12 @@
import org.springframework.test.web.servlet.request.MockMvcRequestBuilders;
import uk.gov.hmcts.reform.pip.account.management.Application;
import uk.gov.hmcts.reform.pip.account.management.config.AzureConfigurationClientTestConfiguration;
import uk.gov.hmcts.reform.pip.account.management.model.AzureAccount;
import uk.gov.hmcts.reform.pip.account.management.model.PiUser;
import uk.gov.hmcts.reform.pip.account.management.model.SystemAdminAccount;

import java.util.ArrayList;
import java.util.List;
import java.util.UUID;

import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.when;
import static org.springframework.http.HttpStatus.BAD_REQUEST;
import static org.springframework.http.HttpStatus.FORBIDDEN;
import static org.springframework.test.web.servlet.result.MockMvcResultMatchers.status;
Expand All @@ -48,70 +36,36 @@
@DirtiesContext(classMode = DirtiesContext.ClassMode.AFTER_EACH_TEST_METHOD)
@WithMockUser(username = "admin", authorities = {"APPROLE_api.request.admin"})
class SystemAdminAccountTest {

private static final String ROOT_URL = "/account";
private static final String CREATE_SYSTEM_ADMIN_URL = ROOT_URL + "/add/system-admin";
private static final String AZURE_PATH = "/azure/";
private static final String CREATE_SYSTEM_ADMIN_URL = ROOT_URL + "/system-admin";

private static final String ISSUER_ID = "1234-1234-1234-1234";
private static final String SYSTEM_ADMIN_ISSUER_ID = "87f907d2-eb28-42cc-b6e1-ae2b03f7bba2";
private static final String ISSUER_HEADER = "x-issuer-id";
private static final String GIVEN_NAME = "Given Name";
private static final String ID = "1234";
private static final String TEST_SYS_ADMIN_SURNAME = "testSysAdminSurname";
private static final String TEST_SYS_ADMIN_FIRSTNAME = "testSysAdminFirstname";
private static final String TEST_SYS_ADMIN_EMAIL = "testSysAdminEmail@justice.gov.uk";
private static final String FORBIDDEN_STATUS_CODE = "Status code does not match forbidden";
private static final String SQL_ADD_ADMIN = "classpath:add-admin-users.sql";

private static final ObjectMapper OBJECT_MAPPER = new ObjectMapper();

@Autowired
private MockMvc mockMvc;

@Autowired
GraphServiceClient graphClient;

@Autowired
UsersRequestBuilder usersRequestBuilder;


@Autowired
ApiException apiException;

@BeforeAll
static void startup() {
OBJECT_MAPPER.findAndRegisterModules();
}

@BeforeEach
void setup() {
User user = new User();
user.setId(ID);
user.setGivenName(GIVEN_NAME);

List<User> azUsers = new ArrayList<>();
azUsers.add(user);

when(graphClient.users()).thenReturn(usersRequestBuilder);
when(usersRequestBuilder.post(any())).thenReturn(user);

UserCollectionResponse userCollectionResponse = new UserCollectionResponse();
userCollectionResponse.setValue(azUsers);

when(usersRequestBuilder.get(any())).thenReturn(userCollectionResponse);
}

@AfterEach
public void reset() {
Mockito.reset(graphClient, usersRequestBuilder);
}

@Test
@Sql(executionPhase = Sql.ExecutionPhase.BEFORE_TEST_METHOD, scripts = "classpath:add-admin-users.sql")
void testCreateSystemAdminAccount() throws Exception {
@Sql(executionPhase = Sql.ExecutionPhase.BEFORE_TEST_METHOD, scripts = SQL_ADD_ADMIN)
void testUserCanCreateSystemAdminAccount() throws Exception {
SystemAdminAccount systemAdmin = new SystemAdminAccount();
systemAdmin.setFirstName(TEST_SYS_ADMIN_FIRSTNAME);
systemAdmin.setSurname(TEST_SYS_ADMIN_SURNAME);
systemAdmin.setEmail(TEST_SYS_ADMIN_EMAIL);
systemAdmin.setProvenanceUserId(UUID.randomUUID().toString());

MockHttpServletRequestBuilder createRequest =
MockMvcRequestBuilders
Expand All @@ -135,12 +89,13 @@ void testCreateSystemAdminAccount() throws Exception {
}

@Test
@Sql(executionPhase = Sql.ExecutionPhase.BEFORE_TEST_METHOD, scripts = "classpath:add-admin-users.sql")
@Sql(executionPhase = Sql.ExecutionPhase.BEFORE_TEST_METHOD, scripts = SQL_ADD_ADMIN)
void testCreateSystemAdminAccountRequestExceeded() throws Exception {
SystemAdminAccount systemAdmin1 = new SystemAdminAccount();
systemAdmin1.setFirstName("testSysAdminFirstname1");
systemAdmin1.setSurname("testSysAdminSurname1");
systemAdmin1.setEmail("testSysAdminEmai1l@justice.gov.uk");
systemAdmin1.setProvenanceUserId(UUID.randomUUID().toString());

MockHttpServletRequestBuilder createRequest1 =
MockMvcRequestBuilders
Expand All @@ -156,6 +111,7 @@ void testCreateSystemAdminAccountRequestExceeded() throws Exception {
systemAdmin2.setFirstName("testSysAdminFirstname2");
systemAdmin2.setSurname("testSysAdminSurname2");
systemAdmin2.setEmail("testSysAdminEmai12@justice.gov.uk");
systemAdmin2.setProvenanceUserId(UUID.randomUUID().toString());

MockHttpServletRequestBuilder createRequest2 =
MockMvcRequestBuilders
Expand All @@ -173,12 +129,11 @@ void testCreateSystemAdminAccountRequestExceeded() throws Exception {
}

@Test
@Sql(executionPhase = Sql.ExecutionPhase.BEFORE_TEST_METHOD, scripts = "classpath:add-admin-users.sql")
void testGetAzureUserInfo() throws Exception {
@Sql(executionPhase = Sql.ExecutionPhase.BEFORE_TEST_METHOD, scripts = SQL_ADD_ADMIN)
void testCreateSystemAdminReturnsBadRequest() throws Exception {
SystemAdminAccount systemAdmin = new SystemAdminAccount();
systemAdmin.setFirstName(TEST_SYS_ADMIN_FIRSTNAME);
systemAdmin.setSurname(TEST_SYS_ADMIN_SURNAME);
systemAdmin.setEmail(TEST_SYS_ADMIN_EMAIL);

MockHttpServletRequestBuilder createRequest =
MockMvcRequestBuilders
Expand All @@ -188,41 +143,27 @@ void testGetAzureUserInfo() throws Exception {
.contentType(MediaType.APPLICATION_JSON);

MvcResult responseCreateSystemAdminUser = mockMvc.perform(createRequest)
.andExpect(status().isOk()).andReturn();

PiUser returnedUser = OBJECT_MAPPER.readValue(
responseCreateSystemAdminUser.getResponse().getContentAsString(),
PiUser.class
);

MockHttpServletRequestBuilder getRequest = MockMvcRequestBuilders
.get(ROOT_URL + AZURE_PATH + returnedUser.getProvenanceUserId());

MvcResult responseGetUser =
mockMvc.perform(getRequest).andExpect(status().isOk()).andReturn();
.andExpect(status().isBadRequest()).andReturn();

AzureAccount returnedAzureAccount = OBJECT_MAPPER.readValue(
responseGetUser.getResponse().getContentAsString(),
AzureAccount.class
);
assertEquals(returnedUser.getEmail(), returnedAzureAccount.getEmail(),
"Should return the correct user"
assertEquals(BAD_REQUEST.value(), responseCreateSystemAdminUser.getResponse().getStatus(),
"Should return bad request"
);
}

@Test
@WithMockUser(username = "unauthroized_user", authorities = {"APPROLE_unknown.user"})
void testUnauthorizedCreateSystemAdminAccount() throws Exception {
@Sql(executionPhase = Sql.ExecutionPhase.BEFORE_TEST_METHOD, scripts = SQL_ADD_ADMIN)
void testNonSystemAdminIsForbiddenToCreateSystemAdminAccount() throws Exception {
SystemAdminAccount systemAdmin = new SystemAdminAccount();
systemAdmin.setFirstName(TEST_SYS_ADMIN_FIRSTNAME);
systemAdmin.setSurname(TEST_SYS_ADMIN_SURNAME);
systemAdmin.setEmail(TEST_SYS_ADMIN_EMAIL);
systemAdmin.setProvenanceUserId(UUID.randomUUID().toString());

MockHttpServletRequestBuilder createRequest =
MockMvcRequestBuilders
.post(CREATE_SYSTEM_ADMIN_URL)
.content(OBJECT_MAPPER.writeValueAsString(systemAdmin))
.header(ISSUER_HEADER, ISSUER_ID)
.header(ISSUER_HEADER, "87f907d2-eb28-42cc-b6e1-ae2b03f7bba3")
.contentType(MediaType.APPLICATION_JSON);

MvcResult responseCreateSystemAdminUser = mockMvc.perform(createRequest)
Expand Down
Loading

0 comments on commit 10e6565

Please sign in to comment.