PUB-2249 - Refactor MI Endpoints to use Models #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KianKwa
reviewed
Nov 26, 2024
| ); | ||
|
|
||
| assertEquals(6, miData.size(), VALIDATION_MI_REPORT); |
There was a problem hiding this comment.
Don't understand why is this has a size 6. Does it reply on the data from other tests in this class
There was a problem hiding this comment.
This is an error on my part - I added it as part of debugging for the test below and forgot to remove it. Have removed now :)
KianKwa
reviewed
Nov 26, 2024
| @Query("SELECT new uk.gov.hmcts.reform.pip.model.report.AccountMiData(" | ||
| + "u.userId, u.provenanceUserId, u.userProvenance, u.roles, u.createdDate, u.lastSignedInDate) " | ||
| + "FROM PiUser u") | ||
| List<AccountMiData> getAccManDataForMI(); |
There was a problem hiding this comment.
This is not your change but while you are there are you OK to rename the method name to something like getAccountDataForMi() or getMiData() or getAccountMiData(), etc.? 'AccMan' does not sound good :)
KianKwa
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/PUB-2249
Change description
Update MI endpoints to use data models rather than strings
Does this PR introduce a breaking change? (check one with "x")