PUB-2574 - Add functional tests for system admin and bulk creation #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisS1512
requested changes
Dec 13, 2024
...ctionalTest/java/uk/gov/hmcts/reform/pip/account/management/controllers/BulkAccountTest.java
Outdated
Show resolved
Hide resolved
| public void teardown() throws IOException { | ||
| File mockFile = new File(System.getProperty(MOCK_FILE)); | ||
|
|
||
| List<String> emails = Files.lines(mockFile.toPath(), StandardCharsets.UTF_8) |
There was a problem hiding this comment.
Rather than needing to parse the original file, I'm thinking you could use a standard prefix that all accounts in this test use.
E.g pip-am-test-email--
This way you'll be able to call the delete request just once with pip-am-test-email- and it'll delete them all
...ctionalTest/java/uk/gov/hmcts/reform/pip/account/management/controllers/BulkAccountTest.java
Outdated
Show resolved
Hide resolved
ChrisS1512
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/PUB-2574
Change description
Add functional tests for bulk media account creation and system admin account creation
Does this PR introduce a breaking change? (check one with "x")