PUB-2576 - Add functional tests for audit logs #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisS1512
requested changes
Dec 23, 2024
...ionalTest/java/uk/gov/hmcts/reform/pip/account/management/controllers/AuditCreationTest.java
Outdated
Show resolved
Hide resolved
| assertThat(retrievedAuditLog.getUserEmail()).isEqualTo(auditLog.getUserEmail()); | ||
| } | ||
|
|
||
| @Test |
There was a problem hiding this comment.
I think we'll run into the issues with the below when it runs on the master pipeline due to master linking up to the Staging DB and the numbers below not matching.
To fix this, I'd suggest using the functionality in the recently merged PUB-1909, to filter based on email alongside the page sizes below to ensure it will always return a consistent result
src/main/java/uk/gov/hmcts/reform/pip/account/management/database/AuditRepository.java
Outdated
Show resolved
Hide resolved
...in/java/uk/gov/hmcts/reform/pip/account/management/controllers/TestingSupportController.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA link (if applicable)
https://tools.hmcts.net/jira/browse/PUB-2576
Change description
Add functional tests for audit log endpoints in AuditController
Does this PR introduce a breaking change? (check one with "x")