Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PUB-2572 - Functional Tests #468

Merged
merged 7 commits into from
Dec 24, 2024

Conversation

ChrisS1512
Copy link
Contributor

JIRA link (if applicable)

https://tools.hmcts.net/jira/browse/PUB-2572

Change description

Added functional tests for

  • Account Controller
  • Account Filtering Controller
  • Azure Account Controller

Does this PR introduce a breaking change? (check one with "x")

[ ] Yes
[x] No

@ChrisS1512 ChrisS1512 changed the base branch from master to freeze December 19, 2024 15:36
@@ -107,6 +122,17 @@ protected Response doPutRequest(final String path, final Map<String, String> add
.thenReturn();
}

protected Response doPutRequestWithBody(final String path,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This new method here looks identical to the one right below it. Can we just keep one of them?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good spot :) I've removed this now

@ChrisS1512 ChrisS1512 merged commit f699b7f into freeze Dec 24, 2024
5 checks passed
@ChrisS1512 ChrisS1512 deleted the PUB-2572-Functional-Tests-For-Accounts branch December 24, 2024 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants