Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Fiasco! #36

Closed
slifty opened this issue Aug 30, 2015 · 2 comments
Closed

Version Fiasco! #36

slifty opened this issue Aug 30, 2015 · 2 comments

Comments

@slifty
Copy link
Contributor

slifty commented Aug 30, 2015

Our version numbers are kind of out of control. The repo has the following versions listed depending on where you look:

0.3.0 (branch version)
1.0.0 (version listed in application.properties)
0.0.1 (this may just be local to me...)
v3 (version in the URL)
Version 2 (version in the repo description)

Proposed resolutions:

  • I'd like to see the application.properties field automatically updated OR removed until we get to the point where we figure out an automated solution
  • Dev versions should be merged back to master (since I think it's master) and tagged with 3.0.0 since we are not actually in 0.*
  • URL stays the same
  • repo description removes any mention of version.
@kfogel
Copy link
Member

kfogel commented Jan 28, 2016

I've started working on this, based on the plan @slifty originally proposed in this thread. So far I have done the following:

  • Merged feature-compass_schema into 0.3.0.
  • Merged 0.3.0 into master, resolving a trivial conflict in API.md.
  • Tagged resultant commit 902e18c as 3.0.0.
  • Created new milestone branch 3.1.0.

We still need to archive these branches so they don't distract us (typically I do that by putting them in the archive/ tag namespace, but will look around to see if any better conventions have arisen):

  • Oauth2.0.1
  • Oauth2.0.1---Ashaar
  • 0.2.1
  • feature-heroku
  • feature-logs
  • demo-client
  • feature-errors

Once the above is done I'll see if anything remains in this issue, but I think that will address most of it. Possibly we should either update the version number in src/main/resources/application.properties.example to "3.1.0" or we should stop maintaining a version number there altogether.

kfogel added a commit that referenced this issue Jan 31, 2016
As per issue #36, this number's maintenance may be automated later.
For now, the number can at least be up to date.
@kfogel
Copy link
Member

kfogel commented Feb 1, 2016

Okay, the application.properties thing is now tracked in issue #40, and all those old branches have been moved to archival tags:

0.2.1                   -->  archive/0.2.1
Oauth2.0.1              -->  archive/Oauth2.0.1
Oauth2.0.1---Ashaar     -->  archive/Oauth2.0.1---Ashaar
demo-client             -->  archive/demo-client
feature-compass_schema  -->  archive/feature-compass_schema
feature-errors          -->  archive/feature-errors
feature-heroku          -->  archive/feature-heroku
feature-logs            -->  archive/feature-logs

Closing this issue.

@kfogel kfogel closed this as completed Feb 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants