Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually maintaining application.version in application.properties.example is unwieldy. #40

Open
kfogel opened this issue Jan 31, 2016 · 0 comments

Comments

@kfogel
Copy link
Member

kfogel commented Jan 31, 2016

Transfering this sub-issue over here from issue #36:

Summary says it all. We should either automate the maintenance of this version number, or else update the relevant step in INSTALL.md (see commit 96ac954) to instruct the user in how to update the version number themselves.

kfogel added a commit that referenced this issue Jan 31, 2016
This takes care of a documentation need that we've actually had since
commit de763e6: when `src/main/resources/application.properties`
was renamed to `application.properties.example`, that meant that the
live application's properties file wouldn't be created at install time
without some kind of extra step.  The result was that if you visited
`openhmis/api/v3/healthcheck`, you would see

    Your service is working with version

instead of, e.g. this:

    Your service is working with version 3.1.0

For now, the solution is just to add a manual step in INSTALL.md, but
some day we should automate this as part of the Maven deploy.  (Note
that this problem is separate from the problem of keeping the version
number itself up-to-date, which is discussed in issue #40.)
@kfogel kfogel mentioned this issue Feb 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant