Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core module separation #11257

Merged
merged 2 commits into from
Mar 22, 2025
Merged

Core module separation #11257

merged 2 commits into from
Mar 22, 2025

Conversation

GSMgeeth
Copy link
Collaborator

No description provided.

@GSMgeeth GSMgeeth self-assigned this Mar 21, 2025
@GSMgeeth GSMgeeth requested a review from buddhika75 March 21, 2025 16:05
buddhika75
buddhika75 approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@buddhika75 buddhika75 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All ok. Only double about making Double to double in report template row class. May be in jsf pages, we want to display a blank space instead of a 0.00 in some reports. WIll create an issue again if such instance is found in future.

@GSMgeeth GSMgeeth merged commit 041c22b into development Mar 22, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buddhika75 buddhika75 buddhika75 approved these changes

Assignees

@GSMgeeth GSMgeeth

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GSMgeeth @buddhika75