HOT-FIX: add users name #19
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
avelx
reviewed
Nov 18, 2025
| returnsInProgress <- stampDutyLandTaxService.getReturn(storn, "PENDING") | ||
| submittedReturns <- stampDutyLandTaxService.getReturn(storn, "SUBMITTED") | ||
| dueForDeletion <- stampDutyLandTaxService.getReturn(storn, "DUE_FOR_DELETION") | ||
| optName <- authConnector.authorise(EmptyPredicate,Retrievals.name) |
Contributor
There was a problem hiding this comment.
🔧 - please extract field required on the level of playframework action, in this case it will be available in every controller calling auth, also we are not calling auth connector directly in our custom controllers for sure; only via actions such as: identify andThen getData andThen requireData andThen stornRequiredAction etc
# Conflicts: # app/controllers/manage/AtAGlanceController.scala # test/controllers/manage/AtAGlanceControllerSpec.scala
Contributor
Author
|
test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.