refac get submitted returns to use generic methods #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
avelx
reviewed
Dec 8, 2025
avelx
reviewed
Dec 8, 2025
avelx
reviewed
Dec 8, 2025
| totalRowCount = response.returnSummaryCount | ||
| ) | ||
| case SdltReturnTypes.SUBMITTED_SUBMITTED_RETURNS => | ||
| case SdltReturnTypes.SUBMITTED_SUBMITTED_RETURNS | SdltReturnTypes.SUBMITTED_NO_RECEIPT_RETURNS => |
Contributor
There was a problem hiding this comment.
🔧 - looks like next enum entry SUBMITTED_NO_RECEIPT_RETURNS is redundant, so we can potentially drop it as its not required
Contributor
There was a problem hiding this comment.
I would assume SUBMITTED_NO_RECEIPT_RETURNS is still required ?
…ns-to-use-generic-methods
avelx
reviewed
Dec 8, 2025
| ) | ||
|
|
||
| val paginationText: Option[String] = | ||
| Option.unless(totalRowCount <= 10 || pageIndex <= 0) { |
Contributor
There was a problem hiding this comment.
there are quite a few occurrences of this segment of code / + similar related to pagination testing :
- we can move this into ~ PaginationTestHelper or similar
avelx
reviewed
Dec 8, 2025
|
|
||
| def paginateIfValidPageIndexV2[A]( | ||
| rowsOpt: Option[List[A]], | ||
| def getPaginationWithInfoText[A]( |
Contributor
There was a problem hiding this comment.
I think we can reduce this method to be of "getPaginationWithInfoText"
as we unified types of rows we supporting for each returns page
avelx
approved these changes
Dec 8, 2025
Contributor
avelx
left a comment
avelx
left a comment
There was a problem hiding this comment.
approved with comment: we can apply refactoring in a few places etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.