Canary oct updates #67
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upon an exception being thrown whist POSTing data to Canary, historical data reading will stop. This will ensure that memory is not excessively used by reading more and more historical logs into memory. Historical data reading will resume once the next POST request is successful.
Added a handler for the case where the the Canary API response indicates that the session token is invalid or expired. This handler will bypass checks against the expiration timer. Previously, API responses indicating an invalid or expired session token would be ignored if the expiration timer had not yet expired.
Previously, session expiration updates were triggered when session requests were made, but these requests could fail. This would result in the session being invalid, but the expiration tracker being updated. Now they are made when there is a successful response to get/update session, or when there is a non-failure request not related to session management.
it-hms
force-pushed
the
iatr/read_hault
branch
from
6037fa9 to
f1d75eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues: