Thk v1.15.6 #77
Thk v1.15.6 #77
Conversation
.github/workflows/package-test.yml
Outdated
| # Version: 2.1 | ||
| # | ||
| # This action is configured to automatically run when a push | ||
| # is made or pull request is merged to the `main` or `master` | ||
| # branch. | ||
|
|
||
| name: Compile Test | ||
| name: Package Test |
There was a problem hiding this comment.
What do you think about Package Build Test or Packaging Test? I don't think it's a huge concern, but Package Test just seems off to me.
There was a problem hiding this comment.
This is still in draft. not sure why i added a reviewer yet.
Im fine with "Package Test" or "Build Test", "Package Test" doesnt bother me at all.
There was a problem hiding this comment.
Do you want "Build Test"
There was a problem hiding this comment.
I'm okay with either, although Build Test may be a bit more descriptive as it covers the Javadoc checking too.
TomKimsey
force-pushed
the
THK_v1.15.6
branch
2 times, most recently
from
98f9f52 to
476e1c3
Compare
| @@ -171,6 +171,7 @@ | |||
| <dependencySourceExcludes> | |||
| <dependencySourceExclude>com.hms_networks.americas.sc.mvnlibs:ewon-etk:*</dependencySourceExclude> | |||
| </dependencySourceExcludes> | |||
| <failOnWarnings>true</failOnWarnings> | |||
There was a problem hiding this comment.
This should be carried upstream to the starter project.
.github/workflows/package-test.yml
Outdated
| # Version: 2.1 | ||
| # | ||
| # This action is configured to automatically run when a push | ||
| # is made or pull request is merged to the `main` or `master` | ||
| # branch. | ||
|
|
||
| name: Compile Test | ||
| name: Package Test |
There was a problem hiding this comment.
I'm okay with either, although Build Test may be a bit more descriptive as it covers the Javadoc checking too.
TomKimsey
force-pushed
the
THK_v1.15.6
branch
from
476e1c3 to
3fb9dba
Compare
This test now uses the package command to test both compilation and javadoc creation. This ensures both the code is able to be built and the javadocs are valid.
Javadoc warnings now trigger build to fail to ensure that the documentation is complete and accurate.
No description provided.