Dev/1.15.8 #83
Merged
Dev/1.15.8 #83
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomKimsey
requested changes
Nov 14, 2023
src/main/java/com/hms_networks/americas/sc/extensions/taginfo/TagInfoManager.java
Outdated
Show resolved
Hide resolved
src/main/java/com/hms_networks/americas/sc/extensions/taginfo/TagInfoManager.java
Outdated
Show resolved
Hide resolved
TomKimsey
requested changes
Nov 14, 2023
alexjhawk
force-pushed
the
dev/1.15.8
branch
from
5e86e47 to
08e6799
Compare
TomKimsey
reviewed
Nov 14, 2023
| @@ -371,6 +371,16 @@ private static synchronized void processTagListEBDLine(String line) | |||
| case indexUnit: | |||
| String tagUnit = currentToken; | |||
|
|
|||
| // Remove wrapping quotes if present | |||
| final char quoteChar = '"'; | |||
There was a problem hiding this comment.
should this be named doubleQuoteChar to avoid ambiguity?
There was a problem hiding this comment.
Updated, although I think it is/was fine either way.
At some point, code needs to be considered self-explanatory, otherwise, it introduces unnecessary redundancy. In situations like this, I don't have a hard preference against including variables such as doubleQuoteChar, but I don't think it is better than hardcoded ".
Given the code comment, a hardcoded " should have its meaning easily interpreted, and adding variable(s) can arguably make the code more difficult to follow in some situations simply because it results in longer code blocks.
TomKimsey
requested changes
Nov 14, 2023
| final int firstCharIndex = 0; | ||
| final int secondCharIndex = 1; | ||
| final int lastCharIndex = tagUnit.length() - 1; | ||
| if (tagUnit.charAt(firstCharIndex) == quoteChar |
There was a problem hiding this comment.
Suggested change
| if (tagUnit.charAt(firstCharIndex) == quoteChar | |
| if (tagUnit.charAt(firstCharIndex) == quoteChar |
Removed extra quotes from being included in the unit field of TagInfo objects since the unit field is already a string object and the extra quotes are redundant/confusing.
alexjhawk
force-pushed
the
dev/1.15.8
branch
from
08e6799 to
f28a0b8
Compare
TomKimsey
approved these changes
Nov 14, 2023
it-hms
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.