Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Powershell fix #53

Merged
merged 3 commits into from
Nov 1, 2023
Merged

Powershell fix #53

merged 3 commits into from
Nov 1, 2023

Conversation

TomKimsey
Copy link
Contributor

closes #52

@TomKimsey
Copy link
Contributor Author

@alexjhawk how is this repo being versioned? There is a changelog with version numbers but i dont see that used anywhere.

Also at this point should this have v1.0.0 since its not really in initial development anymore?

@alexjhawk
Copy link
Collaborator

@alexjhawk how is this repo being versioned? There is a changelog with version numbers but i dont see that used anywhere.

Also at this point should this have v1.0.0 since its not really in initial development anymore?

There is no versioning scheme for this project. It does follow SEMVER of course, but I left the value at what Maven set as the default.

I don't have an issue with bumping this project up to 1.0.0, although I am fine with 0.0.1 as-is too since it is the default version number given to Maven projects in many scenarios.

@TomKimsey TomKimsey requested a review from alexjhawk October 31, 2023 19:56
@TomKimsey TomKimsey self-assigned this Oct 31, 2023
@TomKimsey TomKimsey marked this pull request as ready for review October 31, 2023 19:56
@TomKimsey
Copy link
Contributor Author

@alexjhawk feel free to coauthor the release commit to backdate any changes not captured in the changelog.

Co-authored-by: Alex J Hawk (HMS) <alha@hms.se>
@alexjhawk
Copy link
Collaborator

@alexjhawk feel free to coauthor the release commit to backdate any changes not captured in the changelog.

Finished. Feel free to tag me and let me know if there are any changes to address in my additions.

The commit is still (should be) authored to you -- I added myself as a co-author.

@TomKimsey
Copy link
Contributor Author

@alexjhawk feel free to coauthor the release commit to backdate any changes not captured in the changelog.

Finished. Feel free to tag me and let me know if there are any changes to address in my additions.

The commit is still (should be) authored to you -- I added myself as a co-author.

Looks Good

@TomKimsey TomKimsey requested a review from it-hms November 1, 2023 11:55
@TomKimsey TomKimsey merged commit c8e32c9 into main Nov 1, 2023
5 checks passed
@TomKimsey TomKimsey deleted the THK_DEV branch November 1, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VSCode Maven commands are broken in powershell
2 participants