Skip to content

Add user model #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hoangtuyb96 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add user model #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/models/user.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
class User < ApplicationRecord
end
8 changes: 8 additions & 0 deletions db/migrate/20250108170244_create_users.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
class CreateUsers < ActiveRecord::Migration[7.1]
def change
create_table :users do |t|

t.timestamps
end
Comment on lines +3 to +6
Copy link

@coderabbitai coderabbitai bot Jan 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Add essential columns for the users table

The current migration only includes timestamp columns. Consider adding essential columns for user authentication and basic information:

Here's a suggested implementation:

 create_table :users do |t|
+  t.string :email, null: false
+  t.string :password_digest, null: false
+  t.string :username, null: false
+  t.string :first_name
+  t.string :last_name
   t.timestamps
 end
+
+ add_index :users, :email, unique: true
+ add_index :users, :username, unique: true

Key additions:

  • Authentication columns: email, password_digest
  • Basic info: username, first_name, last_name
  • Null constraints on required fields
  • Unique indexes on email and username for quick lookups and preventing duplicates
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
create_table :users do |t|
t.timestamps
end
create_table :users do |t|
t.string :email, null: false
t.string :password_digest, null: false
t.string :username, null: false
t.string :first_name
t.string :last_name
t.timestamps
end
add_index :users, :email, unique: true
add_index :users, :username, unique: true
🧰 Tools
🪛 rubocop (1.69.1)

[convention] 4-5: Extra empty line detected at block body beginning.

(Layout/EmptyLinesAroundBlockBody)

Copy link
Owner Author

@hoangtuyb96 hoangtuyb96 Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this commit, I want to create init table, so we don't need to add those column.

Copy link

@coderabbitai coderabbitai bot Jan 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hoangtuyb96 Understood! That's a valid approach to start with a basic table structure and add columns incrementally through separate migrations. I'll retract my suggestion.

(｀･ω･´)ゞ

✏️ Learnings added 
Learnt from: hoangtuyb96
PR: hoangtuyb96/test_code_rabbit#1
File: db/migrate/20250108170244_create_users.rb:3-6
Timestamp: 2025-01-08T17:05:15.372Z
Learning: When reviewing Rails migrations, allow for incremental table creation where initial migrations may only set up the basic table structure without columns, which can be added in subsequent migrations.

Note: Learnings are effective only in the context of similar code segments. To apply general coding guidelines, please configure review instructions. You can manage existing learnings in the app.

end
end
11 changes: 11 additions & 0 deletions test/fixtures/users.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
# Read about fixtures at https://api.rubyonrails.org/classes/ActiveRecord/FixtureSet.html

# This model initially had no columns defined. If you add columns to the
# model remove the "{}" from the fixture names and add the columns immediately
# below each fixture, per the syntax in the comments below
#
one: {}
# column: value
#
two: {}
# column: value
7 changes: 7 additions & 0 deletions test/models/user_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
require "test_helper"

class UserTest < ActiveSupport::TestCase
# test "the truth" do
# assert true
# end
end