Add missing NumPad keys
#2468
Merged
Add missing NumPad keys
#2468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: Pull Request
about: Add missing keys
title: Add missing
NumPadkeysDescription:
It seems like a couple of
ImGuiKey_s weren't added to DPG. Maybe it used to cause problems in the past, but due to a pretty recent (~2 years ago maybe) update in ImGui, the keys listed in ImGui should be completely cross platform, so I've added alsoNumPadEnterandNumPadEqualCloses #2457 (This doesn't solve the problem of having
mvKey_Returnto refer to both Enter and Return, but I'd say that's never been an intended use case)