chore(profile): add Curtis M-Dillon profile #651

cmdillon · 2025-06-20T06:03:57Z

Adds my profile to ‎profile-submission.json for the Product Designer role.

Closes #648

Summary by CodeRabbit

New Features
- Added profile for Jesse Dean (jediDean).
- Added profile for Curtis Matthiesen-Dillon (cmdillon).
Changes
- Replaced/relocated Shantanu Swami and Ruairidh Orr Ewing entries; Roairdh now lists two trial issue links.
- Removed profiles for Lucky Ivanius, Agung Setiawan, and Jeremy Godfrey.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

…l_name and github_trial_issue_link key-value pairs

coderabbitai · 2025-06-20T06:04:03Z

Walkthrough

Updated profile-submission.json's team_profiles array: added a new top entry for jediDean (Jesse Dean); replaced/reshuffled several existing entries (swapped jaibhedia ↔ cmdillon, updated roars2121 to include two issue links); and removed lucky-ivanius, agung-setiawan, and 0xcoreblock.

Changes

Cohort / File(s)	Change Summary
Profile data `profile-submission.json`	Added `jediDean` at the top; removed `lucky-ivanius`, `agung-setiawan`, and `0xcoreblock`; replaced `jaibhedia` with `cmdillon`; updated `roars2121`/`jaibhedia` blocks so `roars2121` now has two `github_trial_issue_link` entries.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

chore(profile): add profile for Bayu Alpiansyah #238 #246 — Modifies the same team_profiles array in profile-submission.json (adds/removes profile entries).
chore(profile): add profile for Jesse Dean #365 — Adds the jediDean profile entry that also appears in this change.
chore(profile): add profile for Luqmanul Hakim #131 — Touches profile-submission.json and edits the lucky-ivanius profile which is removed in this PR.

Suggested reviewers

markholdex

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Out of Scope Changes check	⚠️ Warning	The PR includes multiple out-of-scope changes: removal of 4 unrelated profile entries (jediDean, lucky-ivanius, agung-setiawan, 0xcoreblock), replacement of jaibhedia/roars2121 entries, and modification of github_trial_issue_link to array format.	Remove all changes unrelated to adding Curtis Matthiesen-Dillon's profile. Only commit the single new cmdillon entry to profile-submission.json.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check	✅ Passed	The PR successfully adds Curtis Matthiesen-Dillon's profile entry with correct github_handle (cmdillon), full_name, and trial issue link `#648`, meeting the core requirement.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title accurately reflects the main change: adding Curtis Matthiesen-Dillon's profile entry to the JSON file.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 0

🧹 Nitpick comments (1)

profile-submission.json (1)
3-7: Inconsistent indentation for the jediDean entry
The indent levels here (8 spaces for { and 12 for keys) don’t match the rest of the file, which uses 4 spaces for objects and 6 for their properties. Please align this block to use 4-space indents for { and 6-space indents for the keys.

Apply this diff to normalize the indentation:
@@ lines 3-7
-        {
-            "github_handle": "jediDean",
-            "full_name": "Jesse Dean",
-            "github_trial_issue_link": "https://github.com/holdex/trial/issues/364"
-        },
+    {
+      "github_handle": "jediDean",
+      "full_name": "Jesse Dean",
+      "github_trial_issue_link": "https://github.com/holdex/trial/issues/364"
+    },

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6ddbc24 and 331ebc4.

📒 Files selected for processing (1)

profile-submission.json (2 hunks)

🔇 Additional comments (1)

profile-submission.json (1)

237-241: New profile entry for cmdillon looks good
The object is appended with the correct keys, values, and comma placement. JSON structure is valid and consistent with existing entries.

holdex · 2025-06-20T06:05:42Z

Time Submission Status

Member	Status	Time	Action	Last Update
cmdillon	✅ Submitted	1h 30min	Update time	Jan 14, 2026, 3:16 PM
tiffmyaaw	✅ Submitted	10min	Update time	Jan 14, 2026, 3:15 PM

tiffmyaaw

Almost. Please rename your PR title and description based on our Guidelines

PR description to link your issue manually should be the one in the same repo, not the other.

Follow this instruction to verify past commits

Last, don't forget to update your time spent on the PR Time Tracker bot.

Feel free to look at the successfully closed PRs in this repo for refs.

…l_name and github_trial_issue_link key-value pairs

…tion-submit

Signed-off-by: Tiffany V. Y. <116727382+tiffmyaaw@users.noreply.github.com>

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 331ebc4 and 9f86383.

📒 Files selected for processing (1)

profile-submission.json (2 hunks)

🔇 Additional comments (2)

profile-submission.json (2)

443-447: cmdillon entry is correctly formatted and aligns with PR objective.

The addition of Curtis Matthiesen-Dillon's profile is accurate:

GitHub handle: cmdillon ✓

Full name: Curtis Matthiesen-Dillon ✓

Issue reference: #648 ✓

JSON structure and syntax are valid ✓

1-679: Critical: File contains multiple duplicate profile entries.

Scanning the file reveals several duplicate profiles that degrade data quality:

jediDean: appears at lines 4–7 and lines 104–107

lucky-ivanius: appears at lines 9–12 and lines 154–157

0xcoreblock: appears at lines 224–227 and lines 654–657

roars2121: appears at lines 449–452 and lines 459–462

agung-setiawan: appears at lines 549–552 and lines 564–567

These duplicates should be removed. If this file is manually maintained, consider adding a merge-check or validation step to prevent future duplicates.

Should these duplicates be deduplicated as part of this PR, or in a separate issue?

profile-submission.json

Signed-off-by: Tiffany V. Y. <116727382+tiffmyaaw@users.noreply.github.com>

Removed entry for Jesse Dean from profile submissions. Signed-off-by: Tiffany V. Y. <116727382+tiffmyaaw@users.noreply.github.com>

Signed-off-by: Tiffany V. Y. <116727382+tiffmyaaw@users.noreply.github.com>

coderabbitai

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@profile-submission.json`:
- Around line 493-500: The profile entry uses an array for
github_trial_issue_link while the schema and other entries expect a string;
change the github_trial_issue_link value in this profile to a single string
(pick one canonical issue URL) so it matches the existing schema, or if you
intend to support arrays update the global schema and all consumers accordingly;
locate the github_trial_issue_link field in the profile-submission.json entry
for "Shantanu Swami" and convert the array to a single string to keep types
consistent with other entries.

📜 Review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9f86383 and ca22f4f.

📒 Files selected for processing (1)

profile-submission.json

🔇 Additional comments (2)

profile-submission.json (2)

3-7: Unrelated change to PR scope.

This PR is for adding cmdillon (issue #648), but this adds jediDean (issue #364). If intentional, consider a separate PR or update the PR description.

489-491: LGTM.

Profile entry for cmdillon correctly added with issue #648 link as intended.

_{✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.}

coderabbitai · 2026-01-14T15:15:45Z

profile-submission.json

    {
      "github_handle": "jaibhedia",
      "full_name": "Shantanu Swami",
-      "github_trial_issue_link": "https://github.com/holdex/trial/issues/680"
-     },
-      {
-      "github_handle": "roars2121",
-      "full_name": "Ruairidh Orr Ewing",
-      "github_trial_issue_link": "https://github.com/holdex/trial/issues/645"
+      "github_trial_issue_link": [
+        "https://github.com/holdex/trial/issues/679",
+        "https://github.com/holdex/trial/issues/680"
+      ]
    },


⚠️ Potential issue | 🟠 Major

Schema inconsistency: array vs string.

github_trial_issue_link is an array here but a string everywhere else. This could break consumers expecting a consistent type.

Either:

Keep it as a string (pick one issue), or

Update the schema definition and all consumers to handle both types

Also, this change is unrelated to the PR objective (adding cmdillon).

🤖 Prompt for AI Agents

In `@profile-submission.json` around lines 493 - 500, The profile entry uses an array for github_trial_issue_link while the schema and other entries expect a string; change the github_trial_issue_link value in this profile to a single string (pick one canonical issue URL) so it matches the existing schema, or if you intend to support arrays update the global schema and all consumers accordingly; locate the github_trial_issue_link field in the profile-submission.json entry for "Shantanu Swami" and convert the array to a single string to keep types consistent with other entries.

Signed-off-by: George Ciubotaru <george@holdex.io>

georgeciubotaru · 2026-01-14T16:25:04Z

@cmdillon, @tiffmyaaw There are more changes than requested, please resolve the conflicts

Signed-off-by: George Ciubotaru <george@holdex.io>

Update profile to include correct information for: github_handle, ful…

331ebc4

…l_name and github_trial_issue_link key-value pairs

coderabbitai bot reviewed Jun 20, 2025

View reviewed changes

tiffmyaaw assigned cmdillon Jun 20, 2025

tiffmyaaw requested changes Jun 20, 2025

View reviewed changes

cmdillon changed the title ~~Update profile to include correct information for: github_handle, ful…~~ Added my profile to profile-submission.json Jun 20, 2025

curtis and others added 2 commits June 20, 2025 18:30

Update profile to include correct information for: github_handle, ful…

a7e5056

…l_name and github_trial_issue_link key-value pairs

Merge branch 'main' of https://github.com/cmdillon/holdex-job-applica…

4c2b3af

…tion-submit

tiffmyaaw changed the title ~~Added my profile to profile-submission.json~~ chore(profile): added Curtis M-Dillon to profile-submission.json Dec 15, 2025

Merge branch 'main' into main

895bed7

Signed-off-by: Tiffany V. Y. <116727382+tiffmyaaw@users.noreply.github.com>

tiffmyaaw previously approved these changes Dec 15, 2025

View reviewed changes

Merge branch 'main' into main

9f86383

coderabbitai bot reviewed Dec 15, 2025

View reviewed changes

profile-submission.json Show resolved Hide resolved

Merge branch 'main' into main

32dfec1

Signed-off-by: Tiffany V. Y. <116727382+tiffmyaaw@users.noreply.github.com>

tiffmyaaw dismissed their stale review via 32dfec1 December 16, 2025 15:37

tiffmyaaw added 2 commits December 16, 2025 22:38

Remove Jesse Dean's profile submission

ea17a09

Removed entry for Jesse Dean from profile submissions. Signed-off-by: Tiffany V. Y. <116727382+tiffmyaaw@users.noreply.github.com>

Clean duplicate entries from JSON

2dc3d31

Signed-off-by: Tiffany V. Y. <116727382+tiffmyaaw@users.noreply.github.com>

tiffmyaaw previously approved these changes Dec 16, 2025

View reviewed changes

tiffmyaaw added 2 commits December 17, 2025 15:34

Merge branch 'main' into main

ec4f598

Merge branch 'main' into main

ca22f4f

coderabbitai bot reviewed Jan 14, 2026

View reviewed changes

Merge branch 'main' into main

fe39cab

Signed-off-by: George Ciubotaru <george@holdex.io>

georgeciubotaru dismissed tiffmyaaw’s stale review via fe39cab January 14, 2026 16:20

Merge branch 'main' into main

fd876a0

Signed-off-by: George Ciubotaru <george@holdex.io>

georgeciubotaru changed the title ~~chore(profile): added Curtis M-Dillon to profile-submission.json~~ chore(profile): add Curtis M-Dillon profile Jan 14, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(profile): add Curtis M-Dillon profile #651

chore(profile): add Curtis M-Dillon profile #651

cmdillon commented Jun 20, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 20, 2025 •

edited

Loading

Uh oh!

coderabbitai bot left a comment

Uh oh!

holdex bot commented Jun 20, 2025 •

edited

Loading

Uh oh!

tiffmyaaw left a comment

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Uh oh!

coderabbitai bot Jan 14, 2026

Uh oh!

georgeciubotaru commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

chore(profile): add Curtis M-Dillon profile #651

Are you sure you want to change the base?

chore(profile): add Curtis M-Dillon profile #651

Conversation

cmdillon commented Jun 20, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

holdex bot commented Jun 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Time Submission Status

Uh oh!

tiffmyaaw left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai bot Jan 14, 2026

Choose a reason for hiding this comment

Uh oh!

georgeciubotaru commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

cmdillon commented Jun 20, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 20, 2025 •

edited

Loading

holdex bot commented Jun 20, 2025 •

edited

Loading