fix: leak out-of-order packet if the read callback destroys the stream (

#213)
holepunchto · Oct 5, 2024 · ad5a271 · ad5a271
1 parent f27b551
commit ad5a271
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/src/udx.c b/src/udx.c
@@ -1305,7 +1305,10 @@ process_packet (udx_socket_t *socket, char *buf, ssize_t buf_len, struct sockadd
 
     if ((pkt->type & UDX_HEADER_DATA) && stream->on_read != NULL) {
       stream->on_read(stream, pkt->buf.len, &(pkt->buf));
-      if (stream->status & UDX_STREAM_DEAD) return 1;
+      if (stream->status & UDX_STREAM_DEAD) {
+        free(pkt);
+        return 1;
+      }
     }
 
     free(pkt);