New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error on end unconnected #217

Merged

jthomas43 merged 2 commits into holepunchto:main from jthomas43:error-on-end-unconnected

Oct 17, 2024

Contributor

jthomas43 commented Oct 17, 2024

return UV_ENOTCONN if user calls udx_stream_write() / udx_stream_write_end() on a stream that is not connected (preventing crash)
return UV_EPIPE if user calls udx_stream_write() / udx_stream_write_end() on a stream that is already ended
return UV_EBUSY if user calls udx_socket_close() on a socket that still has streams. This simplifies behavior, which before allowed packets to be flushed.

jthomas43 added 2 commits

October 16, 2024 18:38


          return UV_ENOTCONN / UV_EPIPE on stream write or write_end if not con…

23fa7d1

…nected or already ended


          UV_EBUSY on socket close if streams are still open

f6502ee

jthomas43 merged commit b1a2583 into holepunchto:main

3 checks passed

jthomas43 deleted the error-on-end-unconnected branch

October 17, 2024 22:43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet