Refactor Hub to drop the Place class #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
holesch
commented
Feb 2, 2024
holesch
commented
- util: Add on_error() context manager
- test_hub: Fixup compatible type
- test_hub: Use jsonrpc for agent
- Hub: Refactor to drop the Place class
Similar to the [example in the contextlib documentation][1]. [1]: https://docs.python.org/3/library/contextlib.html#replacing-any-use-of-try-finally-and-flag-variables
`compatible` is a list according to the model.
When using contextvars, then all methods must be called in the same context as agent_communicate(). Instead of implementing a complete fake serve_forever() method, that executes the methods received through some sort of queue, just reuse jsonrpc with a fake connection.
Move all the logic from the Place classmethods to the Hub singleton. After that, there's no reason to keep the Place class at all. Introduce contextvars for the reservation context and client IP address. Now the _ReservationContext class is unnecessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.