OpenID Connect #58
Merged
OpenID Connect #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following error:
AttributeError: 'FixtureDef' object has no attribute 'unittest'
Disable contextmanager-generator-missing-cleanup: too many false positives.
With even more paths pylint would complain about too many return statements.
The login command can request and store an OpenID Connect ID token. It's not used, yet.
This will optionally refresh the ID token and return it for use in the Authorization HTTP header.
Make sure the auth_info in config is sane and only send known keys to the clients.
With the bidirectional jsonrpc channel it's now possible to use one endpoint again. This makes it easier to integrate authentication, because then there's only one connection handler. Drop the dummy WebSocket authentication. Since ID tokens need to be refreshed, a one time authentication is not enough. Without authentication, all endpoints are the same, even for login.
Allows Hub to authenticate clients.
The class could cache the identity provider responses.
Request the ID token from clients, convert it into roles and check if the required roles are present before executing the RPC call. The ID token is refreshed in a background task. If refreshing fails, then the connection is closed.
This is mostly useful for testing.
Only the classifiers were updated, but not the actual version requirement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.