HTTP Caching #63
Merged
HTTP Caching #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To implement caching, the http module needs to parse response headers. Create a new response object, that stores headers for further processing.
This is a simple implementation which requires users to manage cache objects per request. It doesn't implement conditional requests for revalidation, instead it fetches the complete content again, as soon as the cached response is stale.
The Validator needs to fetch the OpenID Connect configuration and the signing keys of the issuer every time it wants to authenticate a user. Since this can happen quite frequently in the Hub, cache the responses.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Hub needs to fetch data from the issuer to verify ID tokens. To not fetch the data for every user authentication, cache the responses from the issuer.