GitHub actions OIDC #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try reading config file location from environment variable, before falling back to the default path.
This can be used to generate an ID token from an external source, for example GitHub Actions OIDC tokens.
The get_id_token() method was never registered with the websocket channel, so the hub couldn't get an ID token from the agent.
Don't try to load the vhci-hcd Kernel module, when calling `not-my-board status`. The Kernel module is only necessary when the user tries to attach a USB device.
Some issuers don't have all the provider metadata, that is required by the OpenID Connect Discovery specification. For example GitHub Actions doesn't have the `authorization_endpoint`. To validate a token, this endpoint is not necessary, so only require it for login, but not for validation.
Use token source classes to hide the details from users. There are two sources: from file and from command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --token-cmd argument can be used as an alternative to
not-my-board loginin non-interactive environments, like CI.