Ready notification #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hub, Exporter and Agent now write a single line to stdout, which can be used as a ready notification for the service supervisor. For systemd, you can use a wrapper like https://github.com/holesch/sdnotify-wrapper-py
Move startup logic out of ASGI lifespan handler.
Wait for the services to print a line to stdout, instead of waiting for the port to be opened.
Without arguments, parentheses are optional. Remove them to fix ruff PT001 findings.
Having the timeout in polling functions makes them easier to use.
The "I" in "CLI" already stands for interface.
Root user is no longer only required for exporting.
Remove the leftover word from the last rewrite.
With socket activation, the ready notification isn't useful, because the socket is ready before the Agent is started. Disable the ready notification in that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.