Port in status #70
Merged
Port in status #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding new columns after status, one has to account for ANSI escape sequences when aligning the table, because the status column values are printed red or green. At this point maintaining this logic is not worth it and I'd rather add another dependency to the project. Use python-tabulate to format the table. This has the added benefit, that the width of the table is never more than necessary.
Either read the busid from sysfs, when the USB device is attached or calculate the possible busids, when the device is not attached.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Either read the busid from sysfs, when the USB device is attached or
calculate the possible busids, when the device is not attached.