-
Notifications
You must be signed in to change notification settings - Fork 23
refactor!: delete react, lit and vue as selectable ui templates #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor!: delete react, lit and vue as selectable ui templates #536
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
0928381 to
9e81b36
Compare
ThetaSinner
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
9e81b36 to
e29f33d
Compare
mattyg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was assuming we would drop vanilla as well so there was only a single set of templates for generating a UI. Was that not the intention?
|
I dropped vanilla at first as well, but that would mean that the In the end I did what the issue said. Happy to remove vanilla as well as a follow-on. |
e29f33d to
e48082c
Compare
e48082c to
2d7e873
Compare
|
✔️ 2d7e873 - Conventional commits check succeeded. |
depends on #533
resolves #531
hello_worldexample can only be scaffolded withvanillatemplate.forumcan only be scaffolded withsveltetemplate.