Skip to content

Conversation

@jost-s
Copy link
Contributor

@jost-s jost-s commented Jan 16, 2026

depends on #533

resolves #531

  • hello_world example can only be scaffolded with vanilla template.
  • forum can only be scaffolded with svelte template.

@coderabbitai
Copy link

coderabbitai bot commented Jan 16, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch refactor/provide-svelte-as-only-ui-framework

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jost-s jost-s force-pushed the refactor/provide-svelte-as-only-ui-framework branch 2 times, most recently from 0928381 to 9e81b36 Compare January 16, 2026 23:52
@jost-s jost-s requested a review from a team January 17, 2026 12:32
ThetaSinner
ThetaSinner previously approved these changes Jan 19, 2026
Copy link
Member

@ThetaSinner ThetaSinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@jost-s jost-s force-pushed the refactor/provide-svelte-as-only-ui-framework branch from 9e81b36 to e29f33d Compare January 19, 2026 19:24
@jost-s jost-s enabled auto-merge (rebase) January 19, 2026 19:25
Copy link
Member

@mattyg mattyg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was assuming we would drop vanilla as well so there was only a single set of templates for generating a UI. Was that not the intention?

@jost-s
Copy link
Contributor Author

jost-s commented Jan 19, 2026

I dropped vanilla at first as well, but that would mean that the hello-world example would be dropped too, because that only works with vanilla JS.

In the end I did what the issue said. Happy to remove vanilla as well as a follow-on.

ThetaSinner
ThetaSinner previously approved these changes Jan 20, 2026
@jost-s jost-s force-pushed the refactor/provide-svelte-as-only-ui-framework branch from e29f33d to e48082c Compare February 7, 2026 01:57
@jost-s jost-s changed the base branch from main to chore/delete-tryorama-related-code February 7, 2026 01:58
@jost-s jost-s force-pushed the refactor/provide-svelte-as-only-ui-framework branch from e48082c to 2d7e873 Compare February 7, 2026 02:00
@cocogitto-bot
Copy link

cocogitto-bot bot commented Feb 7, 2026

✔️ 2d7e873 - Conventional commits check succeeded.

@jost-s jost-s merged commit d021c75 into chore/delete-tryorama-related-code Feb 7, 2026
1 check passed
@jost-s jost-s deleted the refactor/provide-svelte-as-only-ui-framework branch February 7, 2026 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide support for a single UI framework

3 participants