Skip to content

Conversation

@jost-s
Copy link
Contributor

@jost-s jost-s commented Feb 5, 2026

resolves #533

Summary by CodeRabbit

  • Chores
    • Removed Tryorama testing framework support and public Tryorama version constant from scaffolding.
    • Eliminated numerous Tryorama-dependent test templates, helper functions, and test project configurations across web and UI templates.
  • Documentation
    • Removed a reference to Tryorama from the web-app README.

@coderabbitai
Copy link

coderabbitai bot commented Feb 5, 2026

Walkthrough

This PR removes Tryorama from scaffolding: deletes the TRYORAMA_VERSION constant and tryorama_version template field, and removes Tryorama-based TypeScript test templates and related imports/config for generic and vanilla UI frameworks.

Changes

Cohort / File(s) Summary
Version constants
src/versions.rs
Removed pub const TRYORAMA_VERSION and its npm comment.
Template scaffold data
src/templates/web_app.rs
Removed tryorama_version field from ScaffoldWebAppData and its initialization in scaffold_web_app_template.
Generic test templates (deleted)
templates/generic/collection/tests/.../{{kebab_case collection_name}}.test.ts.hbs, templates/generic/entry-type/tests/.../common.ts.hbs, templates/generic/entry-type/tests/.../{{kebab_case entry_type.name}}.test.ts.hbs, templates/generic/link-type/tests/.../*.test.ts.hbs, templates/generic/coordinator-zome/tests/.../common.ts.hbs
Removed Tryorama/Vitest TypeScript test templates and related helper functions; deleted imports of CallableCell and Holochain client test helpers.
Generic web-app test config (deleted)
templates/generic/web-app/tests/package.json.hbs, templates/generic/web-app/tests/tsconfig.json.hbs, templates/generic/web-app/tests/vitest.config.ts.hbs
Removed Node test project templates (package.json with Tryorama dependency), tsconfig, and Vitest config.
Vanilla UI framework tests (deleted)
templates/ui-frameworks/vanilla/collection/tests/.../{{kebab_case collection_name}}.test.ts.hbs, templates/ui-frameworks/vanilla/entry-type/tests/.../common.ts.hbs, templates/ui-frameworks/vanilla/entry-type/tests/.../{{kebab_case entry_type.name}}.test.ts.hbs, templates/ui-frameworks/vanilla/example/tests/hello-world.test.ts.hbs, templates/ui-frameworks/vanilla/coordinator-zome/tests/.../common.ts.hbs
Removed Tryorama-based test templates and common helpers for the Vanilla UI framework.
Documentation
templates/generic/web-app/README.md.hbs
Removed reference to @holochain/tryorama in documentation.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

Suggested labels

ShouldBackport/0.6

Suggested reviewers

  • mattyg
  • ThetaSinner
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Chore/delete tryorama related code' accurately summarizes the primary change—removing tryorama-related code across multiple source and template files.
Linked Issues check ✅ Passed The PR addresses the key coding requirements from issue #533: removes tryorama version constants from src/versions.rs, removes template data from src/templates/web_app.rs, and deletes all old TypeScript test templates.
Out of Scope Changes check ✅ Passed All changes are directly aligned with issue #533 objectives—removing tryorama references and test templates. No out-of-scope modifications detected.
Docstring Coverage ✅ Passed Docstring coverage is 86.11% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch chore/delete-tryorama-related-code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@src/templates/link_type.rs`:
- Around line 80-83: The current no_spec branch drops the entire "dnas" subtree
by retaining keys not equal to "dnas" which removes necessary zome scaffolding;
instead implement a recursive prune that only removes "tests" directories:
replace the direct retain call inside the no_spec handling of
link_type_template.dir_content_mut() with a call to a new helper (e.g.,
prune_tests_dirs) that walks the FileTree, retains children except "tests" at
each node, and recurses into remaining children so "dnas" and its non-test
contents are preserved.

@jost-s jost-s changed the base branch from main to refactor/add-rust-test-for-links February 5, 2026 19:17
Base automatically changed from refactor/add-rust-test-for-links to main February 6, 2026 13:29
@jost-s jost-s force-pushed the chore/delete-tryorama-related-code branch from 0bc96a4 to 895d9ce Compare February 6, 2026 15:17
@jost-s jost-s requested a review from a team February 7, 2026 01:34
@jost-s jost-s force-pushed the chore/delete-tryorama-related-code branch from d021c75 to 8b29d0c Compare February 7, 2026 02:02
@cocogitto-bot
Copy link

cocogitto-bot bot commented Feb 7, 2026

✔️ 8b29d0c - Conventional commits check succeeded.

@jost-s jost-s merged commit 54c14c1 into main Feb 9, 2026
13 checks passed
@jost-s jost-s deleted the chore/delete-tryorama-related-code branch February 9, 2026 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Switch from tryorama to sweettest

2 participants