ci: Fix ci #127
Merged
ci: Fix ci #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
maximlt
approved these changes
Jan 31, 2025
There was a problem hiding this comment.
New baseline on the right, more shading now and less artifacts.
The test broke because of a change in imshow introduced in Matplotlib 3.10 described here. interpolation_stage now defaults to 'auto' instead of 'data' (I tried running the test with interpolation_stage='data' and it passed).
Co-authored-by: Maxime Liquet <35924738+maximlt@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I shifted to UV because it seemed like the least effort to avoid this error. I disabled the cache because I didn't want a uv.lock or requirement file.
Something has changed in MPL 3.10, so I have split the baseline into two tests.
Using
python -mbecause of the following error on Python 3.7 Windows: